New issue
Advanced search Search tips

Issue 859208 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task



Sign in to add a comment

Revert disable binding management before M69 beta

Project Member Reported by boliu@chromium.org, Jun 29 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4924c30f7d0b6dc8ab57018c534e499052d453e

commit f4924c30f7d0b6dc8ab57018c534e499052d453e
Author: Bo Liu <boliu@chromium.org>
Date: Fri Jun 29 21:58:18 2018

android: Disable binding mangement for site isolation

This is a speculative experiment (since it's a simple change) to see if
it has any effect on the rate of sad tabs when site isolation is
enabled.

This should be reverted before M69 branch point, and definitely before
site isolation actually ships to beta.

Bug: 855037
Bug:  859208 
Change-Id: I90c7cce4a03603d8bd9772ead804eeabb4114bad
Reviewed-on: https://chromium-review.googlesource.com/1120864
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571660}
[modify] https://crrev.com/f4924c30f7d0b6dc8ab57018c534e499052d453e/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/f4924c30f7d0b6dc8ab57018c534e499052d453e/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelperImpl.java

Cc: creis@chromium.org
Components: Internals>Sandbox>SiteIsolation
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1b78a91a591d35bf5da3a76158e7868ca4b7522

commit c1b78a91a591d35bf5da3a76158e7868ca4b7522
Author: Bo <boliu@chromium.org>
Date: Fri Jul 13 16:02:58 2018

Revert "android: Disable binding mangement for site isolation"

This reverts commit f4924c30f7d0b6dc8ab57018c534e499052d453e.

Reason for revert: Done with experiment.

Original change's description:
> android: Disable binding mangement for site isolation
> 
> This is a speculative experiment (since it's a simple change) to see if
> it has any effect on the rate of sad tabs when site isolation is
> enabled.
> 
> This should be reverted before M69 branch point, and definitely before
> site isolation actually ships to beta.
> 
> Bug: 855037
> Bug:  859208 
> Change-Id: I90c7cce4a03603d8bd9772ead804eeabb4114bad
> Reviewed-on: https://chromium-review.googlesource.com/1120864
> Commit-Queue: Bo <boliu@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571660}

TBR=boliu@chromium.org,alexmos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 855037,  859208 
Change-Id: I70917a54a7f3a4c02baa95ddba5016ce7c8948ad
Reviewed-on: https://chromium-review.googlesource.com/1136611
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574936}
[modify] https://crrev.com/c1b78a91a591d35bf5da3a76158e7868ca4b7522/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/c1b78a91a591d35bf5da3a76158e7868ca4b7522/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelperImpl.java

NextAction: ----
Status: Fixed (was: Assigned)

Sign in to add a comment