MediaRecorder always returns Blob type "video/webm" when constructed with no |mimeType| |
||||
Issue description(Orginally spotted in b/110948780). When MediaRecorder is constructed, a mimeType can be passed in the options dictionary; if this is left empty, the platform (i.e. Chrome) can choose whatever it likes. This is OK, but the encoded chunks received in the ondataavailable() event handler should reflect the choice, and instead they always have "video/webm". See the codepen https://codepen.io/miguelao/pen/Nzeeqd (look for "ondataavailable, Blob received with type: ..." in the console.
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59f0d053cfa8bfe6f20d7c1d20503d139e0182e2 commit 59f0d053cfa8bfe6f20d7c1d20503d139e0182e2 Author: Miguel Casas <mcasas@chromium.org> Date: Tue Jul 03 14:45:43 2018 MediaRecorder: Retrieve actual recording mime type if not user-specified This CL introduces a new MediaRecorderHandler::ActualMimeType() method that produces the mimeType used for recording by MRHandler. This method is then called from Blink's MediaRecorder when the user has specified no mime type for recording, so the output Blobs can have the correct type. Bug: 859199 Change-Id: I941f46a2ef495f5ac68995f79319fe6f07836a89 Reviewed-on: https://chromium-review.googlesource.com/1121141 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#572207} [modify] https://crrev.com/59f0d053cfa8bfe6f20d7c1d20503d139e0182e2/content/renderer/media_recorder/media_recorder_handler.cc [modify] https://crrev.com/59f0d053cfa8bfe6f20d7c1d20503d139e0182e2/content/renderer/media_recorder/media_recorder_handler.h [modify] https://crrev.com/59f0d053cfa8bfe6f20d7c1d20503d139e0182e2/content/renderer/media_recorder/media_recorder_handler_unittest.cc [modify] https://crrev.com/59f0d053cfa8bfe6f20d7c1d20503d139e0182e2/third_party/WebKit/LayoutTests/fast/mediarecorder/MediaRecorder-requestData.html [modify] https://crrev.com/59f0d053cfa8bfe6f20d7c1d20503d139e0182e2/third_party/blink/public/platform/web_media_recorder_handler.h [modify] https://crrev.com/59f0d053cfa8bfe6f20d7c1d20503d139e0182e2/third_party/blink/renderer/modules/mediarecorder/media_recorder.cc
,
Aug 13
This should be very fixed: Commit 59f0d053... initially landed in 69.0.3481.0 yuli@ could you please mark as Verified? Thanks
,
Aug 27
,
Aug 30
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mcasas@chromium.org
, Jun 29 2018Summary: MediaRecorder always returns Blob type "video/webm" when constructed with no |mimeType| (was: MediaRecorder always returns Blob type "video/webm" when called with no |mimeType|)