New issue
Advanced search Search tips

Issue 859169 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test http/tests/devtools/layers/layer-scroll-rects-get.js is flaky

Project Member Reported by yigu@chromium.org, Jun 29 2018

Issue description

The following layout test is flaky on win7

http/tests/devtools/layers/layer-scroll-rects-get.js

Layout test result:

--- e:\b\swarm_slave\w\iob2pm04\layout-test-results\http/tests/devtools/layers/layer-scroll-rects-get-expected.txt
+++ e:\b\swarm_slave\w\iob2pm04\layout-test-results\http/tests/devtools/layers/layer-scroll-rects-get-actual.txt
@@ -1,26 +1,4 @@
 Tests scroll rectangles support in in Layers3DViewxScroll rectangles
 
 Scroll rectangles
-{
-    0 : {
-        rect : {
-            height : 20
-            width : 20
-            x : 8
-            y : 8
-        }
-        type : "TouchEventHandler"
-    }
-}
-{
-    0 : {
-        rect : {
-            height : 40
-            width : 40
-            x : 0
-            y : 0
-        }
-        type : "TouchEventHandler"
-    }
-} 
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c591d48b3905436dd83b0d2e52315a31ddc98670

commit c591d48b3905436dd83b0d2e52315a31ddc98670
Author: Yi Gu <yigu@chromium.org>
Date: Fri Jun 29 20:20:39 2018

Mark layout testhttp/tests/devtools/layers/layer-scroll-rects-get.js as flaky

TBR=bokan@chromium.org
NOTRY=true

Bug: 859169
Change-Id: I36dfab32c886820aa2a5416c9e4984b9fce0f110
Reviewed-on: https://chromium-review.googlesource.com/1121080
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571610}
[modify] https://crrev.com/c591d48b3905436dd83b0d2e52315a31ddc98670/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f278255929bf836984dcac1f2bb8bb5dcbffc412

commit f278255929bf836984dcac1f2bb8bb5dcbffc412
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Aug 16 13:27:09 2018

Mark http/tests/devtools/layers/layer-scroll-rects-get.js flaky

Flakiness dashboard shows that it is flaky on all platform

TBR=wjmaclean@chromium.org
NOTRY=true

Bug: 859169
Change-Id: I5c9193cb1e36962c02b6c8d33739bc1687728ac1
Reviewed-on: https://chromium-review.googlesource.com/1177628
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583628}
[modify] https://crrev.com/f278255929bf836984dcac1f2bb8bb5dcbffc412/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by wangxianzhu@chromium.org, Jan 18 (4 days ago)

Cc: bokan@chromium.org
Owner: wangxianzhu@chromium.org
I'll fix the test when I'm working on bug 916768 to ensure enough test coverage.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0f1473ef8c0eff8ed73f59d2129e5296ba6df2b

commit f0f1473ef8c0eff8ed73f59d2129e5296ba6df2b
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jan 18 20:26:26 2019

Rebaseline two http/tests/devtools/layers tests

They had been flaky but they constantly fail recently.
Rebaseline to see if they are still flaky.

TBR=wangxianzhu@chromium.org

Bug: 794180,859169
Change-Id: I682fe6e6f09650f29309b7ee330af4730a76e207
Reviewed-on: https://chromium-review.googlesource.com/c/1422380
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624260}
[modify] https://crrev.com/f0f1473ef8c0eff8ed73f59d2129e5296ba6df2b/third_party/blink/web_tests/http/tests/devtools/layers/layer-compositing-reasons-expected.txt
[modify] https://crrev.com/f0f1473ef8c0eff8ed73f59d2129e5296ba6df2b/third_party/blink/web_tests/http/tests/devtools/layers/layer-scroll-rects-get-expected.txt

Sign in to add a comment