New issue
Advanced search Search tips

Issue 859168 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
samans@chromium.org
ericrk@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 730193



Sign in to add a comment

Remove sync IPC for DisableSwapUntilResize

Project Member Reported by kylec...@chromium.org, Jun 29 2018 
We can potentially remove the sync IPC for DisableSwapUntilResize() with OOP-D. It was added in  crbug.com/811945 . It's not needed at all with direct composition or software compositing as there is already a child HWND. For GPU compositing non-direct composition case we can add a child HWND. We could also potentially revive https://crrev.com/1513053002 and use WindowResizeHelper.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92917104a6fb53a729129e23ae8327aaa5351516

commit 92917104a6fb53a729129e23ae8327aaa5351516
Author: kylechar <kylechar@chromium.org>
Date: Tue Jul 03 21:11:08 2018

Add trace event in DisableSwapUntilResize.

We want to quantify the impact of this IPC and how long the browser is
blocked for.

Bug: 859168
Change-Id: I92835fd097869eedde10894c3caaf1c10157c4a3
Reviewed-on: https://chromium-review.googlesource.com/1121055
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572353}
[modify] https://crrev.com/92917104a6fb53a729129e23ae8327aaa5351516/ui/compositor/host/host_context_factory_private.cc

Comment 3 by kylec...@chromium.org, Nov 27 

It's going to one of the reasons the browser thread janks if the GPU main thread is busy. It's probably not the end of the world the browser thread is blocked too, since if the GPU main thread is blocked we're not drawing anything anyways, but it's not ideal.
►

Sign in to add a comment