New issue
Advanced search Search tips

Issue 859162 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 859151
Owner:
Closed: Jul 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: ----



Sign in to add a comment

not_site_per_process_browser_tests failing on chromium.linux/Linux Tests (dbg)(1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 29 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yigu@chromium.org

not_site_per_process_browser_tests failing on chromium.linux/Linux Tests (dbg)(1)

Builders failed on: 
- Linux Tests (dbg)(1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29

[ RUN ] DistillablePageUtilsBrowserTestAlways.TestDelegate
Xlib: extension "RANDR" missing on display ":99". [31157:31166:0629/115959.365660:ERROR:instance.cc(49)] Unable to locate service manifest for download_manager [31157:31166:0629/115959.374526:ERROR:service_manager.cc(942)] Failed to resolve service name: download_manager [31157:31194:0629/115959.540193:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix") [31157:31157:0629/115959.578297:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [31192:31235:0629/120000.409519:WARNING:file_path_watcher_linux.cc(656)] Watch failed for /etc/../run/resolvconf: No such file or directory (2) [31157:31157:0629/120000.454215:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 [31192:31227:0629/120000.457717:WARNING:simple_synchronous_entry.cc(1254)] Could not open platform files for entry. [31157:31222:0629/120000.621175:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [31157:31157:0629/120001.015712:FATAL:run_loop.cc(216)] Check failed: delegate->active_run_loops_.top()->allow_quit_current_deprecated_. Please migrate off QuitCurrentWhenIdleDeprecated(), e.g. to QuitWhenIdleClosure(). #0 0x0000f75fcca7 base::debug::StackTrace::StackTrace() #1 0x0000f7304d22 base::debug::StackTrace::StackTrace() #2 0x0000f737bd22 logging::LogMessage::~LogMessage() #3 0x0000f74641e9 base::RunLoop::QuitCurrentWhenIdleDeprecated()

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b397350defc64b2c786cb7d209250ca92fa80733

commit b397350defc64b2c786cb7d209250ca92fa80733
Author: Yi Gu <yigu@chromium.org>
Date: Fri Jun 29 19:32:31 2018

Revert "Disallow QuitCurrent*Deprecated() on RunLoops with Quit*Closure()s."

This reverts commit b035cfda675fd58c44789cc3779f2b247f613cb6.

Reason for revert: Failing DistillablePageUtilsBrowserTestAlways.TestDelegate on Linux dbg. See  crbug.com/859162  for crash log.

Original change's description:
> Disallow QuitCurrent*Deprecated() on RunLoops with Quit*Closure()s.
> 
> Use of RunLoop::QuitCurrent*Deprecated() is deprecated, and risky,
> potentially causing unexpected early-exits if run under a different
> RunLoop to the one intended.
> 
> If a caller has taken a Quit*Closure() from the RunLoop then we now
> assume that they intend to use it to quit the loop, and therefore use
> of QuitCurrent*Deprecated() with it must be unintentional.
> 
> Bug:  844016 
> Change-Id: Ib181d0cb34cdba2af29f557646cbe631101bc6b0
> Reviewed-on: https://chromium-review.googlesource.com/1082980
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571499}

TBR=wez@chromium.org,gab@chromium.org,thakis@chromium.org

Change-Id: Ib5e62d0ae045dd7014d3b546d5970c9dac92edd7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  844016 ,  859162 
Reviewed-on: https://chromium-review.googlesource.com/1121037
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571591}
[modify] https://crrev.com/b397350defc64b2c786cb7d209250ca92fa80733/base/files/file_path_watcher_unittest.cc
[modify] https://crrev.com/b397350defc64b2c786cb7d209250ca92fa80733/base/message_loop/message_loop_unittest.cc
[modify] https://crrev.com/b397350defc64b2c786cb7d209250ca92fa80733/base/run_loop.cc
[modify] https://crrev.com/b397350defc64b2c786cb7d209250ca92fa80733/base/run_loop.h
[modify] https://crrev.com/b397350defc64b2c786cb7d209250ca92fa80733/chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
[modify] https://crrev.com/b397350defc64b2c786cb7d209250ca92fa80733/chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc
[modify] https://crrev.com/b397350defc64b2c786cb7d209250ca92fa80733/chrome/common/mac/mock_launchd.cc
[modify] https://crrev.com/b397350defc64b2c786cb7d209250ca92fa80733/chrome/common/mac/mock_launchd.h
[modify] https://crrev.com/b397350defc64b2c786cb7d209250ca92fa80733/chrome/common/service_process_util_mac_unittest.mm

Comment 2 by yigu@chromium.org, Jun 29 2018

Labels: -Sheriff-Chromium
Mergedinto: 859151
Status: Duplicate (was: Available)
Dup into  issue 859151  as they are caused by the same patch which has been reverted via #1.

Comment 3 by w...@chromium.org, Jun 29 2018

Components: Internals>Sandbox>SiteIsolation
Labels: OS-Linux
Owner: w...@chromium.org
Status: Started (was: Duplicate)
Labels: M-69
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cb8dbab0beeafe2b1ccba1c0e99e672abe795ab

commit 0cb8dbab0beeafe2b1ccba1c0e99e672abe795ab
Author: Wez <wez@chromium.org>
Date: Fri Jul 06 19:39:05 2018

Migrate DistillablePageUtils tests off QuitCurrent*Deprecated().

Bug:  844016 ,  859162 
Change-Id: If3e2f53808c5536d10f721b8c004e808769dbc86
Reviewed-on: https://chromium-review.googlesource.com/1125506
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573044}
[modify] https://crrev.com/0cb8dbab0beeafe2b1ccba1c0e99e672abe795ab/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment