CloudPrintProxyPolicyStartupTest.StartAndShutdown is flaky |
|||||
Issue descriptionSuspecting the Runloop change in following patch caused the failure: https://chromium-review.googlesource.com/c/chromium/src/+/1082980 wez@, PTAL. Thanks! [ RUN ] CloudPrintProxyPolicyStartupTest.StartAndShutdown objc[13408]: Class RTCDispatcher is implemented in both /b/s/w/ir/out/Debug/./libcontent.dylib (0x14005f748) and /b/s/w/ir/out/Debug/browser_tests (0x11e34fb88). One of the two will be used. Which one is undefined. [13408:775:0629/105125.016039:1513547145196:WARNING:test_suite.cc(240)] Test launcher output path /var/folders/2j/22s2gz0s7hn48k32d47clxf80000gm/T/.org.chromium.Chromium.ikN8C4/resultsEtudf5/test_results.xml exists. Not adding test launcher result printer. 2018-06-29 10:51:25.025 browser_tests[13407:197713] *** CFMessagePort: bootstrap_register(): failed 1100 (0x44c) 'Permission denied', port = 0x840b, name = '/var/folders/2j/22s2gz0s7hn48k32d47clxf80000gm/T/F80F03C36261EC150B94EBCFDBE1874143AB14F1.srv' See /usr/include/servers/bootstrap_defs.h for the error codes. ../../chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc:453: Failure Value of: exited Actual: false Expected: true Stack trace: 0 libbase.dylib 0x000000012c7180ec base::debug::StackTrace::StackTrace() + 28 1 browser_tests 0x000000010ed0299a StackTraceGetter::CurrentStackTrace(int, int) + 90 2 browser_tests 0x000000010ed269e7 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 71 3 browser_tests 0x000000010ed25d5b testing::internal::AssertHelper::operator=(testing::Message const&) const + 139 4 browser_tests 0x000000010e889a7f CloudPrintProxyPolicyStartupTest::ShutdownAndWaitForExitWithTimeout(base::Process) + 559 5 browser_tests 0x000000010e88a1a9 CloudPrintProxyPolicyStartupTest_StartAndShutdown_Test::TestBody() + 425 ../../chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc:454: Failure Expected equality of these values: 0 exit_code Which is: -100 Stack trace: 0 libbase.dylib 0x000000012c7180ec base::debug::StackTrace::StackTrace() + 28 1 browser_tests 0x000000010ed0299a StackTraceGetter::CurrentStackTrace(int, int) + 90 2 browser_tests 0x000000010ed269e7 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 71 3 browser_tests 0x000000010ed25d5b testing::internal::AssertHelper::operator=(testing::Message const&) const + 139 4 browser_tests 0x000000010e889b40 CloudPrintProxyPolicyStartupTest::ShutdownAndWaitForExitWithTimeout(base::Process) + 752 5 browser_tests 0x000000010e88a1a9 CloudPrintProxyPolicyStartupTest_StartAndShutdown_Test::TestBody() + 425 [ FAILED ] CloudPrintProxyPolicyStartupTest.StartAndShutdown (10680 ms)
,
Jun 29 2018
yigu: Looks like this is a CloudPrint test, and that you see it flake on Mac, in M69, correct? Adding the missing tags to the bug - please correct if necessary.
,
Jun 29 2018
I was not sure about the components. Thanks for adding them.
,
Jun 29 2018
Issue 859162 has been merged into this issue.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a855e2432413570b7cff4d62b9acfcf18bc1c1b commit 4a855e2432413570b7cff4d62b9acfcf18bc1c1b Author: Yi Gu <yigu@chromium.org> Date: Fri Jun 29 19:41:22 2018 Resume the test CloudPrintProxyPolicyStartupTest.StartAndShutdown TBR=wez@chromium.org NOTRY=true Bug: 859151 Change-Id: I5ed4767890dc5da367564a393521f24c0fcf3e3c Reviewed-on: https://chromium-review.googlesource.com/1121040 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571597} [modify] https://crrev.com/4a855e2432413570b7cff4d62b9acfcf18bc1c1b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
,
Jun 29 2018
yigu: No problem - thanks for confirming, and for filing a bug for the regression! +rockot, who migrated the CloudPrint proxy code to public Mojo APIs recently.
,
Jun 29 2018
,
Jun 29 2018
,
Jun 30 2018
Issue 859263 has been merged into this issue.
,
Jun 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e0c2251695f9f7ee5d3bb645bbcdb031a89e6fc commit 5e0c2251695f9f7ee5d3bb645bbcdb031a89e6fc Author: Yi Gu <yigu@chromium.org> Date: Sat Jun 30 03:41:49 2018 Disable test that should be using the new API QuitClosure TBR=wez@chromium.org NOTRY=True Bug: 859151 Change-Id: Id45c6e679ea50523e99a72cf9ae52a7bd1254286 Reviewed-on: https://chromium-review.googlesource.com/1121631 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571755} [modify] https://crrev.com/5e0c2251695f9f7ee5d3bb645bbcdb031a89e6fc/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
,
Jul 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fcc6147752fbb6221bbf8e9ab756d87fa85eca6 commit 2fcc6147752fbb6221bbf8e9ab756d87fa85eca6 Author: Wez <wez@chromium.org> Date: Mon Jul 02 19:56:17 2018 Revert "Disable test that should be using the new API QuitClosure" This reverts commit 5e0c2251695f9f7ee5d3bb645bbcdb031a89e6fc. Reason for revert: This test will now be fixed as part of re-landing the QuitCurrent*Deprecated() cleanup. Original change's description: > Disable test that should be using the new API QuitClosure > > TBR=wez@chromium.org > NOTRY=True > > Bug: 859151 > Change-Id: Id45c6e679ea50523e99a72cf9ae52a7bd1254286 > Reviewed-on: https://chromium-review.googlesource.com/1121631 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571755} TBR=wez@chromium.org,yigu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859151 Change-Id: I94df8df53bc4f58a9c676365db997ab920aa811d Reviewed-on: https://chromium-review.googlesource.com/1122937 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#571977} [modify] https://crrev.com/2fcc6147752fbb6221bbf8e9ab756d87fa85eca6/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9ef2f5a512ed2beba769761848c0cdd472a61e9 commit b9ef2f5a512ed2beba769761848c0cdd472a61e9 Author: Wez <wez@chromium.org> Date: Mon Jul 09 21:20:55 2018 Migrate ServiceProcess and MockLaunchd to use RunLoop::QuitClosure(). Use of RunLoop::QuitCurrent*Deprecated() is deprecated, and risky, potentially causing unexpected early-exits if run under a different RunLoop to the one intended. Bug: 844016 , 859151 Change-Id: Ib38310c0feeec09dbaac6cb74ffd061476e30cf3 Reviewed-on: https://chromium-review.googlesource.com/1123763 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573449} [modify] https://crrev.com/b9ef2f5a512ed2beba769761848c0cdd472a61e9/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [modify] https://crrev.com/b9ef2f5a512ed2beba769761848c0cdd472a61e9/chrome/common/mac/mock_launchd.cc [modify] https://crrev.com/b9ef2f5a512ed2beba769761848c0cdd472a61e9/chrome/common/mac/mock_launchd.h [modify] https://crrev.com/b9ef2f5a512ed2beba769761848c0cdd472a61e9/chrome/common/service_process_util_mac_unittest.mm [modify] https://crrev.com/b9ef2f5a512ed2beba769761848c0cdd472a61e9/chrome/service/service_main.cc [modify] https://crrev.com/b9ef2f5a512ed2beba769761848c0cdd472a61e9/chrome/service/service_process.cc [modify] https://crrev.com/b9ef2f5a512ed2beba769761848c0cdd472a61e9/chrome/service/service_process.h
,
Jul 9
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jun 29 2018