JS ts_mon client library |
|||||||||||
Issue descriptionWrite a shared JS library for reporting client-side timeseries metrics to ts_mon infrastructure. This would enable us to monitor and configure alerts for client-side performance issues. - Should (probably) use pRPC for transport. - Should be accompanied by server-side handlers in Go and Python. - Should include some boilerplate metrics collected from https://developer.mozilla.org/en-US/docs/Web/API/Performance_API
,
Jul 16
,
Jul 16
,
Jul 16
,
Jul 16
,
Jul 23
,
Jul 31
,
Jul 31
,
Jul 31
,
Jul 31
,
Sep 28
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/e378989fb66e7ba9fd3ccaaa1b8b240b50de814b commit e378989fb66e7ba9fd3ccaaa1b8b240b50de814b Author: Sean McCullough <seanmccullough@chromium.org> Date: Fri Sep 28 14:37:31 2018 [chops-fe] ts_mon javascript client This adds a very simple JS client that works similarly to the Go and Python server-side libraries. It doesn't do extensive type checking on the client. Server-side proxy handlers should be added in subsequent CLs. Context: https://docs.google.com/document/d/1Qf39Y1DyD3RYCFyrLSOQVHoNvo3Pw3ddMSXzvpGSqto/edit# Bug: 859148 Change-Id: Ibcdbe79e614944b3cf308af64b41b56728985b3d Reviewed-on: https://chromium-review.googlesource.com/1137431 Commit-Queue: Sean McCullough <seanmccullough@chromium.org> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#17943} [modify] https://crrev.com/e378989fb66e7ba9fd3ccaaa1b8b240b50de814b/crdx/chopsui/test/index.html [add] https://crrev.com/e378989fb66e7ba9fd3ccaaa1b8b240b50de814b/crdx/chopsui/test/tsmon-client_test.html [add] https://crrev.com/e378989fb66e7ba9fd3ccaaa1b8b240b50de814b/crdx/chopsui/tsmon-client.js
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/d5ee5438757af9c66f36cb3b37dca4cda7466ac1 commit d5ee5438757af9c66f36cb3b37dca4cda7466ac1 Author: Jeff Carpenter <jeffcarp@chromium.org> Date: Tue Oct 02 22:22:11 2018 [chopsui] Fixups to tsmon-client.js This CL contains a few fixes for TSMonClient: - Wrap setTimeout handler in arrow function to preserve scope - Change from allowing this.xsrfToken to allowing this.fetchImpl to be implemented in a subclass. This flexibility is required for integrating into Monorail. - Fix typo in defaultValue. Bug: 859148 Change-Id: I9b37e38fdcb3be3b8640965fa74c71b3b2ea5c43 Reviewed-on: https://chromium-review.googlesource.com/c/1257562 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Cr-Commit-Position: refs/heads/master@{#18010} [modify] https://crrev.com/d5ee5438757af9c66f36cb3b37dca4cda7466ac1/crdx/chopsui/tsmon-client.js
,
Oct 3
Closing since the library itself landed in crrev.com/c/1137431. Follow-up changes can be assigned subsequent bugs. Thanks!
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/f180224abaa156a340f9fdd7f9d756420c3f82b3 commit f180224abaa156a340f9fdd7f9d756420c3f82b3 Author: Jeff Carpenter <jeffcarp@chromium.org> Date: Mon Oct 08 21:37:21 2018 [chopsui] tsmon-client.js fixups: ms to seconds and more Includes: - Measure start_time in seconds not ms (back-end expects seconds) - Add back sending XSRF token - More logging - Fix Map.length -> Map.size Bug: 859148 Change-Id: If1b40ccd1b9215296ff389473cf1bf11724f93c5 Reviewed-on: https://chromium-review.googlesource.com/c/1258586 Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Cr-Commit-Position: refs/heads/master@{#18154} [modify] https://crrev.com/f180224abaa156a340f9fdd7f9d756420c3f82b3/crdx/chopsui/test/tsmon-client_test.html [modify] https://crrev.com/f180224abaa156a340f9fdd7f9d756420c3f82b3/crdx/chopsui/tsmon-client.js |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by jeffcarp@chromium.org
, Jul 16