New issue
Advanced search Search tips

Issue 859139 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 821009



Sign in to add a comment

Convert chrome/browser/sync_file_system/drive_backend/sync_engine.cc to NetworkConnectionTracker

Project Member Reported by xunji...@chromium.org, Jun 29 2018

Issue description

SyncEngine currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.


https://cs.chromium.org/chromium/src/chrome/browser/sync_file_system/drive_backend/sync_engine.cc?rcl=9bc221409571d695d0ee31557351841a7d8a5462&l=684
 
 
Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54738f900d49964f01fa7d1bbdf7d39dde268106

commit 54738f900d49964f01fa7d1bbdf7d39dde268106
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Wed Jul 11 01:07:49 2018

Migrate SyncEngine to NetworkConnectionTracker.

This migrates SyncEngine from using

net::NetworkChangeNotifier to content::NetworkConnectionTracker, which

works with the network service enabled.

Bug:  859139 
Change-Id: I8ec4d755c0a6ec854403f66d89ad22a6be47f467
Reviewed-on: https://chromium-review.googlesource.com/1123712
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574022}
[modify] https://crrev.com/54738f900d49964f01fa7d1bbdf7d39dde268106/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
[modify] https://crrev.com/54738f900d49964f01fa7d1bbdf7d39dde268106/chrome/browser/sync_file_system/drive_backend/sync_engine.h

Status: Fixed (was: Started)

Sign in to add a comment