New issue
Advanced search Search tips

Issue 859138 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 6
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 821009



Sign in to add a comment

Convert chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc to NetworkConnectionTracker

Project Member Reported by xunji...@chromium.org, Jun 29 2018

Issue description

MutableProfileOAuth2TokenServiceDelegate currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.


https://cs.chromium.org/chromium/src/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc?rcl=9bc221409571d695d0ee31557351841a7d8a5462&l=879
 
 
Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62066318fa5a47b7a85064351310f4c66fde5945

commit 62066318fa5a47b7a85064351310f4c66fde5945
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Fri Jul 06 19:22:11 2018

Migrate MutableProfileOAuth2TokenServiceDelegate to NetworkConnectionTracker

This migrates MutableProfileOAuth2TokenServiceDelegate from using
net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
works with the network service enabled.

Bug:  859138 
Change-Id: Ief59738e2f9a955d36fc61e345e47cc9c82017c3
Reviewed-on: https://chromium-review.googlesource.com/1123707
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573034}
[modify] https://crrev.com/62066318fa5a47b7a85064351310f4c66fde5945/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
[modify] https://crrev.com/62066318fa5a47b7a85064351310f4c66fde5945/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
[modify] https://crrev.com/62066318fa5a47b7a85064351310f4c66fde5945/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment