Issue metadata
Sign in to add a comment
|
Convert chrome/browser/signin/force_signin_verifier.cc to using NetworkConnectionTracker |
||||||||||||||||||||||
Issue descriptionForceSigninVerifier currently uses net::NetworkChangeNotifier to receive network changes. With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs. https://cs.chromium.org/chromium/src/chrome/browser/signin/force_signin_verifier.cc?rcl=9bc221409571d695d0ee31557351841a7d8a5462&l=86
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa419b17b2bd2addeefffe0bdb44e0392eb144f5 commit aa419b17b2bd2addeefffe0bdb44e0392eb144f5 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Wed Jul 11 00:42:11 2018 Migrate ForceSigninVerifier to NetworkConnectionTracker. This migrates ForceSigninVerifier from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 859136 Change-Id: I59bda75125f09664c5611fbebed89beb175ecc71 Reviewed-on: https://chromium-review.googlesource.com/1123695 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#573998} [modify] https://crrev.com/aa419b17b2bd2addeefffe0bdb44e0392eb144f5/chrome/browser/signin/force_signin_verifier.cc [modify] https://crrev.com/aa419b17b2bd2addeefffe0bdb44e0392eb144f5/chrome/browser/signin/force_signin_verifier.h [modify] https://crrev.com/aa419b17b2bd2addeefffe0bdb44e0392eb144f5/chrome/browser/signin/force_signin_verifier_unittest.cc
,
Jul 11
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rmcelrath@chromium.org
, Jul 3Status: Started (was: Available)