New issue
Advanced search Search tips

Issue 859135 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 821009



Sign in to add a comment

Migrate chrome/browser/sessions/tab_loader_delegate.cc to NetworkConnectionTracker

Project Member Reported by xunji...@chromium.org, Jun 29 2018

Issue description

TabLoaderDelegateImpl currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.

https://cs.chromium.org/chromium/src/chrome/browser/sessions/tab_loader_delegate.cc?rcl=9bc221409571d695d0ee31557351841a7d8a5462&l=96
 
 
Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98f8c0299e8a5e1c7669374b152c070df38f41a7

commit 98f8c0299e8a5e1c7669374b152c070df38f41a7
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Wed Jul 11 17:57:57 2018

Migrate TabLoaderDelegate to NetworkConnectionTracker.

This migrates TabLoaderDelegate from using
net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
works with the network service enabled.

Bug:  859135 
Change-Id: I311155771618328dbceaf9e8f84815f9b24b7ac7
Reviewed-on: https://chromium-review.googlesource.com/1123691
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574242}
[modify] https://crrev.com/98f8c0299e8a5e1c7669374b152c070df38f41a7/chrome/browser/sessions/tab_loader_delegate.cc

Sign in to add a comment