New issue
Advanced search Search tips

Issue 859133 link

Starred by 1 user
Status: Fixed
Owner:
rmcelrath@chromium.org
Closed: Jul 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 821009



Sign in to add a comment

Migrate chrome/browser/media/router/discovery/dial/dial_registry.cc to NetworkConnectionTracker

Project Member Reported by xunji...@chromium.org, Jun 29 2018 
DialRegistry currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.


https://cs.chromium.org/chromium/src/chrome/browser/media/router/discovery/dial/dial_registry.cc?rcl=7ec4a3efb227417051ef7c7f4a949ef5ce38e101&l=353

Comment 1 by rmcelrath@chromium.org, Jul 2

Owner: rmcelrath@chromium.org
Status: Started (was: Available)

Comment 2 by dxie@chromium.org, Jul 12

Labels: OS-Windows
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf9692cef4a23a457228cd18e08524e96d41918

commit 5cf9692cef4a23a457228cd18e08524e96d41918
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Fri Jul 20 20:09:15 2018

Migrate DialRegistry to NetworkConnectionTracker

This migrates DialRegistry from using
net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
works with the network service enabled.

Bug:  859133 
Change-Id: I123782968fe75b2eed3c1c7fc06355ae2d108afe
Reviewed-on: https://chromium-review.googlesource.com/1123648
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576963}
[modify] https://crrev.com/5cf9692cef4a23a457228cd18e08524e96d41918/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/5cf9692cef4a23a457228cd18e08524e96d41918/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc
[modify] https://crrev.com/5cf9692cef4a23a457228cd18e08524e96d41918/chrome/browser/media/router/discovery/dial/dial_registry.cc
[modify] https://crrev.com/5cf9692cef4a23a457228cd18e08524e96d41918/chrome/browser/media/router/discovery/dial/dial_registry.h
[modify] https://crrev.com/5cf9692cef4a23a457228cd18e08524e96d41918/chrome/browser/media/router/discovery/dial/dial_registry_unittest.cc

Comment 4 by rmcelrath@chromium.org, Jul 20

Status: Fixed (was: Started)
►

Sign in to add a comment