New issue
Advanced search Search tips

Issue 859131 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-Servicification

Blocking:
issue 821009



Sign in to add a comment

Migrate chrome/browser/intranet_redirect_detector.cc to using NetworkConnectionTracker

Project Member Reported by xunji...@chromium.org, Jun 29 2018

Issue description

IntranetRedirectDetector currently uses net::NetworkChangeNotifier to receive network changes. 

With network service, that will need to be converted to using NetworkConnectionTracker's observer APIs.


https://cs.chromium.org/chromium/src/chrome/browser/intranet_redirect_detector.cc?rcl=7ec4a3efb227417051ef7c7f4a949ef5ce38e101&l=194
 
Blocking: 821009
Owner: rmcelrath@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a98fd2d86a6bf70497e52e5bfc564bce0998b93

commit 0a98fd2d86a6bf70497e52e5bfc564bce0998b93
Author: Robbie McElrath <rmcelrath@chromium.org>
Date: Tue Jul 03 17:47:52 2018

Migrate intranet_redirect_detector to NetworkConnectionTracker.

This migrates IntranetRedirectDetector from using
net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
works with the network service enabled.

Bug:  859131 
Change-Id: Iec4c2f7907066d030d8de11d13ac955a558a2415
Reviewed-on: https://chromium-review.googlesource.com/1123332
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572280}
[modify] https://crrev.com/0a98fd2d86a6bf70497e52e5bfc564bce0998b93/chrome/browser/intranet_redirect_detector.cc
[modify] https://crrev.com/0a98fd2d86a6bf70497e52e5bfc564bce0998b93/chrome/browser/intranet_redirect_detector.h

Status: Fixed (was: Started)

Sign in to add a comment