Add same-origin sim test to ad_tracker_test |
||
Issue descriptionWe need to verify that we're properly labeling same-origin ad frames as ads. The two situations we should test: 1) A same-origin subframe is created by an ad script with a url on the original origin. The url shouldn't be picked up by the subresource filter. The subframe should be marked as an ad. 2) A same-origin subframe is created by an ad script and its contents are doc.written. The subframe should be marked as an ad.
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c1b7a0d327d462715047240195ab44ef0fc2829 commit 7c1b7a0d327d462715047240195ab44ef0fc2829 Author: John Delaney <johnidel@chromium.org> Date: Tue Jul 10 13:15:17 2018 Add SimTests for same-origin frames made by adscript Add two simtests. 1) A same-origin subframe is created by an ad script with a url on the original origin. The url shouldn't be picked up by the subresource filter. The subframe should be marked as an ad. 2) A same-origin subframe is created by an ad script and its contents are doc.written. The subframe should be marked as an ad. Bug: 859127 Change-Id: Ib970ab41e83b29ec436e91c5743e8c2e3b4c019d Reviewed-on: https://chromium-review.googlesource.com/1125164 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573702} [modify] https://crrev.com/7c1b7a0d327d462715047240195ab44ef0fc2829/third_party/blink/renderer/core/frame/ad_tracker_test.cc
,
Jul 10
|
||
►
Sign in to add a comment |
||
Comment 1 by johnidel@chromium.org
, Jul 3Status: Assigned (was: Available)