lucifer admin-task doesn't use file store, leads to task failure |
||||
Issue descriptionexample failed task: https://chrome-swarming.appspot.com/task?id=3e656dc16f6a5b10&refresh=10&show_raw=1 lucifer_admin_task: 2018/06/29 10:34:57 Exiting with error: task Repair failed: RunAutoserv: exited 1 run task main.innerMain /var/tmp/portage/chromeos-base/lucifer-0.0.1-r108/work/lucifer-0.0.1/src/lucifer/cmd/lucifer_admin_task/main.go:68 main.main /var/tmp/portage/chromeos-base/lucifer-0.0.1-r108/work/lucifer-0.0.1/src/lucifer/cmd/lucifer_admin_task/main.go:38 runtime.main /usr/lib/go/src/runtime/proc.go:198 runtime.goexit /usr/lib/go/src/runtime/asm_amd64.s:2361 @@@STEP_CLOSED@@@ skylab_swarming_worker: 2018/06/29 10:34:58 Ignored error in deferred function (dump bot dimensions failed): <nil> skylab_swarming_worker: 2018/06/29 10:34:58 Error running admin task: exit status 1 run lucifer failed main.runAdminTask /var/tmp/portage/chromeos-base/lucifer-0.0.1-r108/work/lucifer-0.0.1/src/lucifer/cmd/skylab_swarming_worker/main.go:222 main.main /var/tmp/portage/chromeos-base/lucifer-0.0.1-r108/work/lucifer-0.0.1/src/lucifer/cmd/skylab_swarming_worker/main.go:65 runtime.main /usr/lib/go/src/runtime/proc.go:198 runtime.goexit /usr/lib/go/src/runtime/asm_amd64.s:2361 The problem is that the autoserv command line doesn't include the -local-only-host-info and the --host-info-subdir flags. This causes autoserv to hit the AFE for various things.
,
Jun 29 2018
This problem wasn't seen with a reset task a few days ago: https://chrome-swarming.appspot.com/task?id=3e56eed7d120d710 Could be that somthing changed / or that it's a difference between reset/repair tasks.
,
Jun 29 2018
https://chromium-review.googlesource.com/c/chromiumos/infra/lucifer/+/1121078
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/08e46a915f8a06d3c5e379924903074c2f0407cf commit 08e46a915f8a06d3c5e379924903074c2f0407cf Author: Allen Li <ayatane@google.com> Date: Fri Jun 29 22:43:45 2018 lucifer_admin_task: Pass hostinfo settings For lucifer_run_job, HostInfoSubDir is passed around as an argument. However, I dont think HostInfoSubDir should be parametrized. We dont use a different value anywhere and theres no use case for a different value. BUG= chromium:859123 TEST=None Change-Id: I7a5461b050d4dc476a9f9025c5d4783514681d58 Reviewed-on: https://chromium-review.googlesource.com/1121078 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/08e46a915f8a06d3c5e379924903074c2f0407cf/src/lucifer/autotest/atutil/types.go
,
Jul 2
,
Jul 2
The report in #5 is from this morning, if #4 landed 2 days ago, skylab-drones should have already picked up the changes...
,
Jul 2
Ah, ok #6.
,
Jul 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/fa44555516bb3429c00121f04ec10c249eb2c1a7 commit fa44555516bb3429c00121f04ec10c249eb2c1a7 Author: Allen Li <ayatane@google.com> Date: Mon Jul 02 21:18:30 2018 lucifer_admin_task: Fix hostinfo settings Fix silly bug using ResultsDir instead of hostInfoSubDir in https://chromium-review.googlesource.com/c/chromiumos/infra/lucifer/+/1121078 BUG= chromium:859123 TEST=None Change-Id: I7775c57d555c4ca1e65f7c7753ee42ea7c1b9d2e Reviewed-on: https://chromium-review.googlesource.com/1123156 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/fa44555516bb3429c00121f04ec10c249eb2c1a7/src/lucifer/autotest/atutil/types.go
,
Jul 17
Seems like this is needed in the current phase (mark skylab-based paladin important) Fixed?
,
Jul 17
Should be. Wait for a green run and all blocker bugs can be marked verified en masse.
,
Jul 18
|
||||
►
Sign in to add a comment |
||||
Comment 1 by pprabhu@chromium.org
, Jun 29 2018Owner: ayatane@chromium.org
Status: Assigned