New issue
Advanced search Search tips

Issue 859108 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Extensions Click-to-Script: Finalize shadowing treatment for toolbar badging

Project Member Reported by jawag@chromium.org, Jun 29 2018

Issue description

We need to finalize the shadowing treatment for "requesting access" state in the toolbar.
 
Status: Assigned (was: Untriaged)
Labels: Proj-Crx-Cts
Cc: karandeepb@chromium.org

Comment 4 by bklmn@chromium.org, Jun 30 2018

Labels: OS-iOS
The shadow treatment on the badge should align with our Chrome Desktop GM2 shadow (per our original spec). 

Link to "+2+" GM2 shadow detail:
https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g3232c09376_6_896

For hover, click, and focus states...those will display behind the badge and the badge itself will maintain its UI. Might need to iterate on this once we can see the new badge with the shadowing. 
Screen Shot 2018-06-29 at 7.06.58 PM.png
82.7 KB View Download
Screen Shot 2018-06-29 at 7.08.37 PM.png
112 KB View Download

Comment 5 by bklmn@chromium.org, Jun 30 2018

In GM2 (post M69) the hover state is 28px, and the BTS badge is 24px. In my screenshot you can see the "red spot" which is where I intend the dabge to sit with the 16px icon on top. I added mocks of what the hover and focus states would look like. 
Group.png
21.4 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faee83dfe6fb84d53ebd79432c12c619de9fa72d

commit faee83dfe6fb84d53ebd79432c12c619de9fa72d
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Thu Jul 19 06:20:59 2018

Extensions: Update blocked actions badge UI.

This CL updates the UI for extension icons in the browser toolbar that have had
actions blocked on a page. For such extension icons, a white circular badge is
shown behind the extension icon with surrounding shadows.

This removes the ToolbarActionButtonState enum added in r558481 and the
associated plumbing. This is an artifact of the fact that the the extension icon
UI does not depend on the button state now.

BUG= 834494 ,  859108 

Change-Id: I9da8963451ad4f7e09e539d57b96d9d3591d0ba5
Reviewed-on: https://chromium-review.googlesource.com/1141352
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576393}
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/cocoa/extensions/browser_action_button.mm
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/extensions/extension_action_view_controller.cc
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/extensions/extension_action_view_controller.h
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/extensions/icon_with_badge_image_source.cc
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/extensions/icon_with_badge_image_source.h
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/toolbar/media_router_action.h
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/toolbar/test_toolbar_action_view_controller.cc
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h
[delete] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/chrome/browser/ui/toolbar/toolbar_action_button_state.h
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/toolbar/toolbar_action_view_controller.h
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/faee83dfe6fb84d53ebd79432c12c619de9fa72d/chrome/browser/ui/views/toolbar/toolbar_action_view.h

The UI should be available on Canary now. Joel can you check and update the bug if the UI seems good (we can then close this bug) or if you want to iterate on it further. 

Note: on Mac, you'd want to use a Views browser for the top chrome while checking the UI.
Labels: -OS-iOS
Loved this nice surprise in today's Canary. Ill evaluate and update here any concerns. 

Comment 10 Deleted

bklmn@, can we close this out?
Status: Verified (was: Assigned)

Sign in to add a comment