New issue
Advanced search Search tips

Issue 859077 link

Starred by 1 user
Status: Fixed
Owner:
johnidel@chromium.org
Closed: Jul 19
Cc:
csharrison@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Create SubresourceFilter.AdTagging metrics

Project Member Reported by jkarlin@chromium.org, Jun 29 2018 
SubresourceFilter.AdDelay.SecureInfo and SubresourceFilter.AdDelay.IsolatedInfo are very useful metrics to ads in general and not strictly to whether or not we add delay. Let's rename these to

SubresourceFilter.AdTagging.SecureInfo and SubresourceFilter.AdTagging.IsolatedInfo.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/643f659ad1f636e9b92656a0579d4e27b52f34b6

commit 643f659ad1f636e9b92656a0579d4e27b52f34b6
Author: John Delaney <johnidel@chromium.org>
Date: Mon Jul 16 17:19:24 2018

Rename SubresourceFilter AdDelay metrics

The AdDelay historgram metrics aren't strictly used when AdDelay is on.

Bug:  859077 
Change-Id: I2ced2154a45e22cadf9f0ce48f9976ee9ecd2e49
Reviewed-on: https://chromium-review.googlesource.com/1120740
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575323}
[modify] https://crrev.com/643f659ad1f636e9b92656a0579d4e27b52f34b6/components/subresource_filter/content/common/ad_delay_throttle.cc
[modify] https://crrev.com/643f659ad1f636e9b92656a0579d4e27b52f34b6/components/subresource_filter/content/common/ad_delay_throttle_unittest.cc
[modify] https://crrev.com/643f659ad1f636e9b92656a0579d4e27b52f34b6/tools/metrics/histograms/histograms.xml

Comment 2 by johnidel@chromium.org, Jul 19

Status: Fixed (was: Assigned)
After some discussion, names were changed to Ads.Features.ResourceIsSecure and Ads.Features.AdResourceIsIsolated.
►

Sign in to add a comment