New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859063 link

Starred by 4 users
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Some IPC tests are flaky

Project Member Reported by yigu@chromium.org, Jun 29 2018 
ExtensionWebRequestApiTest.ExtensionRequests and SecurityExploitBrowserTest.InterstitialCommandFromUnderlyingContent are flaky on Win7 dbg.

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyzwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKYAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcwMDExL2NvbnRlbnRfYnJvd3NlcnRlc3RzL1UyVmpkWEpwZEhsRmVIQnNiMmwwUW5KdmQzTmxjbFJsYzNRdVNXNTBaWEp6ZEdsMGFXRnNRMjl0YldGdVpFWnliMjFWYm1SbGNteDVhVzVuUTI5dWRHVnVkQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Disabling the flaky tests as the suspicious patch has been landed longer enough to be reverted safely.

Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1114462 is the cause. rockot@, can you take a look?

They all failed a DCHECK

[ RUN      ] ExtensionWebRequestApiTest.ExtensionRequests
...
[6540:5920:0628/213524.646:FATAL:platform_handle_in_transit.cc(118)] Check failed: handle_.is_valid().
Backtrace:
	base::debug::StackTrace::StackTrace [0x6E9F9986+102]
	base::debug::StackTrace::StackTrace [0x6E9F8A2B+27]
	logging::LogMessage::~LogMessage [0x6EA5E254+148]
	mojo::edk::PlatformHandleInTransit::TransferToProcess [0x5BD001D0+512]
	base::circular_deque<std::unique_ptr<mojo::edk::Channel::Message,std::default_delete<mojo::edk::Channel::Message> > >::circular_deque<std::unique_ptr<mojo::edk::Channel::Message,std::default_delete<mojo::edk::Channel::Message> > > [0x5BC9170A+762]
	mojo::edk::NodeChannel::WriteChannelMessage [0x5BCC9334+452]
	mojo::edk::NodeChannel::EventMessageFromRelay [0x5BCCABFF+367]
	mojo::edk::NodeController::OnRelayEventMessage [0x5BCDA1C2+914]
	mojo::edk::NodeChannel::OnChannelMessage [0x5BCCBF0A+4218]
	mojo::edk::Channel::OnReadComplete [0x5BC8C008+1928]
	scoped_refptr<mojo::edk::Channel>::operator bool [0x5BC96294+276]
	base::circular_deque<std::unique_ptr<mojo::edk::Channel::Message,std::default_delete<mojo::edk::Channel::Message> > >::circular_deque<std::unique_ptr<mojo::edk::Channel::Message,std::default_delete<mojo::edk::Channel::Message> > > [0x5BC92075+3173]
	base::MessagePumpForIO::WaitForIOCompletion [0x6EAA5D36+262]
	base::MessagePumpForIO::DoRunLoop [0x6EAA5B62+82]
	base::MessagePumpWin::Run [0x6EAA3FE9+185]
	base::MessageLoop::Run [0x6EA98106+486]
	base::RunLoop::Run [0x6EB63218+488]
	base::Thread::Run [0x6EC2B987+375]
	content::BrowserProcessSubThread::IOThreadRun [0x5EE7ABF0+48]
	content::BrowserProcessSubThread::Run [0x5EE7AAD9+313]
	base::Thread::ThreadMain [0x6EC2C195+1221]
	base::PlatformThread::GetCurrentThreadPriority [0x6EC1EA26+934]
	BaseThreadInitThunk [0x7672337A+18]
	RtlInitializeExceptionChain [0x77BA9882+99]
	RtlInitializeExceptionChain [0x77BA9855+54]

Comment 1 by yigu@chromium.org, Jun 29 2018 

 Issue 859019  has been merged into this issue.

Comment 2 by yigu@chromium.org, Jun 29 2018 

 Issue 858986  has been merged into this issue.

Comment 3 by grunell@chromium.org, Jun 29 2018 

 Issue 859065  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2827c607405db0b04027597297f8bad5b95c6466

commit 2827c607405db0b04027597297f8bad5b95c6466
Author: Yi Gu <yigu@chromium.org>
Date: Fri Jun 29 14:03:26 2018

Mark test ExtensionWebRequestApiTest.ExtensionRequests as flaky

TBR=grunell@chromium.org
NOTRY=true

Bug:  859063 
Change-Id: Iafc22ff3f54532562e53c7c0a11f1fe2e3c4c157
Reviewed-on: https://chromium-review.googlesource.com/1120157
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571461}
[modify] https://crrev.com/2827c607405db0b04027597297f8bad5b95c6466/chrome/browser/extensions/api/web_request/web_request_apitest.cc

Comment 5 by yigu@chromium.org, Jun 29 2018

Description: Show this description

Comment 6 by yigu@chromium.org, Jun 29 2018

Description: Show this description
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b4f35d2ca14cff129de03a29b1a06b3c7200697

commit 7b4f35d2ca14cff129de03a29b1a06b3c7200697
Author: Yi Gu <yigu@chromium.org>
Date: Fri Jun 29 14:29:54 2018

Update disabled ExtensionWebRequestApiTest

TBR=grunell@chromium.org
NOTRY=true

Bug:  859063 
Change-Id: Ie4248ed7493c81f946734678ddea9c228a8c0c24
Reviewed-on: https://chromium-review.googlesource.com/1120160
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571466}
[modify] https://crrev.com/7b4f35d2ca14cff129de03a29b1a06b3c7200697/chrome/browser/extensions/api/web_request/web_request_apitest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09229b5c10252e40dc03320bb33d0f4b7feb7e9d

commit 09229b5c10252e40dc03320bb33d0f4b7feb7e9d
Author: Yi Gu <yigu@chromium.org>
Date: Fri Jun 29 14:31:11 2018

Make InterstitialCommandFromUnderlyingContent flaky on win7

TBR=grunell@chromium.org
NOTRY=true

Bug:  859063 
Change-Id: Idc773b6de9d9a729ce298f6f950dfc6e818fa269
Reviewed-on: https://chromium-review.googlesource.com/1120161
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571467}
[modify] https://crrev.com/09229b5c10252e40dc03320bb33d0f4b7feb7e9d/content/browser/security_exploit_browsertest.cc

Comment 9 by roc...@chromium.org, Jun 29 2018

Status: Started (was: Assigned)
Thanks for updating the tests. Tiny fix incoming: https://chromium-review.googlesource.com/c/chromium/src/+/1120430
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45eb70f5edafe719c1713ee51bb44f37322dd08a

commit 45eb70f5edafe719c1713ee51bb44f37322dd08a
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Jun 29 15:55:39 2018

Mojo: Avoid inappropriate DCHECK when sending invalid handles

It should be safe to send invalid Windows HANDLE values over Mojo, as
we apparently have code relying on this already. Make sure we don't
hit a DCHECK in that case.

TBR=jcivelli@chromium.org

Bug:  859063 
Change-Id: I8c9c0c3a31a5904b28a75b78ba74c22440afd83b
Reviewed-on: https://chromium-review.googlesource.com/1120430
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571493}
[modify] https://crrev.com/45eb70f5edafe719c1713ee51bb44f37322dd08a/mojo/edk/system/channel_win.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab8013f4dd82e8057255d40c8522085a9f080b81

commit ab8013f4dd82e8057255d40c8522085a9f080b81
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Jun 29 15:57:25 2018

Revert "Update disabled ExtensionWebRequestApiTest"

This reverts commit 7b4f35d2ca14cff129de03a29b1a06b3c7200697.

Reason for revert: Test should be fixed now

Original change's description:
> Update disabled ExtensionWebRequestApiTest
> 
> TBR=grunell@chromium.org
> NOTRY=true
> 
> Bug:  859063 
> Change-Id: Ie4248ed7493c81f946734678ddea9c228a8c0c24
> Reviewed-on: https://chromium-review.googlesource.com/1120160
> Reviewed-by: Yi Gu <yigu@chromium.org>
> Reviewed-by: Henrik Grunell <grunell@chromium.org>
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571466}

TBR=grunell@chromium.org,yigu@chromium.org

Change-Id: I6ff7a455c9b06d5f0ef2a341a76d176e2d49ff84
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  859063 
Reviewed-on: https://chromium-review.googlesource.com/1120467
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571494}
[modify] https://crrev.com/ab8013f4dd82e8057255d40c8522085a9f080b81/chrome/browser/extensions/api/web_request/web_request_apitest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18274c3601cf5d6ca1b4d59404024504f4a17e1f

commit 18274c3601cf5d6ca1b4d59404024504f4a17e1f
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Jun 29 16:11:55 2018

Revert "Mark test ExtensionWebRequestApiTest.ExtensionRequests as flaky"

This reverts commit 2827c607405db0b04027597297f8bad5b95c6466.

Reason for revert: Test should be fixed.

Original change's description:
> Mark test ExtensionWebRequestApiTest.ExtensionRequests as flaky
> 
> TBR=grunell@chromium.org
> NOTRY=true
> 
> Bug:  859063 
> Change-Id: Iafc22ff3f54532562e53c7c0a11f1fe2e3c4c157
> Reviewed-on: https://chromium-review.googlesource.com/1120157
> Reviewed-by: Yi Gu <yigu@chromium.org>
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571461}

TBR=grunell@chromium.org,yigu@chromium.org

Change-Id: I32320486bbd0202ef5afe7ea1fa261bafe14269b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  859063 
Reviewed-on: https://chromium-review.googlesource.com/1120468
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571500}
[modify] https://crrev.com/18274c3601cf5d6ca1b4d59404024504f4a17e1f/chrome/browser/extensions/api/web_request/web_request_apitest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55ff92f2008fc1f5e566fbaf483436626df7e0a3

commit 55ff92f2008fc1f5e566fbaf483436626df7e0a3
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Jun 29 16:12:44 2018

Revert "Make InterstitialCommandFromUnderlyingContent flaky on win7"

This reverts commit 09229b5c10252e40dc03320bb33d0f4b7feb7e9d.

Reason for revert: Test should be fixed

Original change's description:
> Make InterstitialCommandFromUnderlyingContent flaky on win7
> 
> TBR=grunell@chromium.org
> NOTRY=true
> 
> Bug:  859063 
> Change-Id: Idc773b6de9d9a729ce298f6f950dfc6e818fa269
> Reviewed-on: https://chromium-review.googlesource.com/1120161
> Reviewed-by: Yi Gu <yigu@chromium.org>
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571467}

TBR=grunell@chromium.org,yigu@chromium.org

Change-Id: Id8fc15b3f1cb08a5e285b5be1f4d03aba03cbb8a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  859063 
Reviewed-on: https://chromium-review.googlesource.com/1120469
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571501}
[modify] https://crrev.com/55ff92f2008fc1f5e566fbaf483436626df7e0a3/content/browser/security_exploit_browsertest.cc

Comment 14 by roc...@chromium.org, Jun 29 2018

Status: Fixed (was: Started)

Comment 16 by roc...@chromium.org, Jun 29 2018 

Are we seeing that fail beyond r571493? If so do you have a link?

Comment 17 by yigu@chromium.org, Jun 29 2018 

It was before r571493. Will keep an eye on it.

Comment 18 by roc...@chromium.org, Jun 29 2018 

If the failures look like the same stack at the top, I'm pretty confident
the problem is universally solved by that CL.

Comment 20 by yigu@chromium.org, Jun 29 2018 

I don't think they are related and the latest failure on Mac10.12 included your fix. Will file a new bug. Thanks.

Comment 21 by roc...@chromium.org, Jun 29 2018 

Yeah, looks unrelated to me.

Comment 22 by roc...@chromium.org, Jun 29 2018 

My fix was for Windows only, but the Mac failures appear unrelated in any case.
►

Sign in to add a comment