New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859055 link

Starred by 2 users
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Jul 10
Cc:
█ sindhu.chelamcherla@chromium.org
bsep@chromium.org
ligim...@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Theme color doesn't reflect on tabs in tabstrip

Project Member Reported by sindhu.chelamcherla@chromium.org, Jun 29 2018 
Chrome Version: 69.0.3476.0
OS: Windows, Linux

What steps will reproduce the problem?
(1) Launch chrome and install any theme (say https://chrome.google.com/webstore/detail/black-green-shards/cojkleigdijnbfecdhjigpgalhfhkdee)
(2) Open 3-3 tabs, observe color of other tabs 

Expected: All the tabs should have added theme color.
Actual: Only focused tab has theme color and other tabs have white color font.

NOTE: 
1. This issue is not seen on setting UI Layout for the browser's top chrome flag to (Normal) in M-69. Seen with (Default/Refresh) 
2. Issue is not seen in M-67 and M-68 even on selecting (Default/Normal/Refresh) from drop down.

Comment 1 by sindhu.chelamcherla@chromium.org, Jun 29 2018

Cc: ligim...@chromium.org
Attaching screenshot for reference.
Tab name color.PNG
22.9 KB View Download

Comment 2 by bsep@chromium.org, Jun 29 2018

Cc: -kylixrd@chromium.org
Owner: kylixrd@chromium.org
This is kinda-sorta intentional, but it does look a bit off. Over to Allen for triage.

Comment 3 by sindhu.chelamcherla@chromium.org, Jul 3

Labels: Proj-MdRefresh

Comment 4 by robliao@chromium.org, Jul 3

Status: Assigned (was: Untriaged)
Marking assigned and to kylixrd@ for investigation.

Comment 5 by robliao@chromium.org, Jul 3 

Is the stable behavior also the same?

Comment 6 by bettes@chromium.org, Jul 3 

From stable
Screen Shot 2018-07-03 at 9.12.03 AM.png
131 KB View Download

Comment 7 by kylixrd@chromium.org, Jul 9 

Overall, this theme doesn't work well with the new tab style. The *active* tab isn't visible, whereas all the inactive ones are.
InactiveTabThemeText.png
21.0 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/767b6ae40b6c85897595dd2a579e0f4e400cc04a

commit 767b6ae40b6c85897595dd2a579e0f4e400cc04a
Author: Allen Bauer <kylixrd@chromium.org>
Date: Tue Jul 10 16:02:59 2018

Update GetTabForegroundColor to use theme color if it's defined by the provider.

Bug:  859055 
Change-Id: I3a29d37292035ea9863210bf47e1a9ad3716d738
Reviewed-on: https://chromium-review.googlesource.com/1129854
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573755}
[modify] https://crrev.com/767b6ae40b6c85897595dd2a579e0f4e400cc04a/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc

Comment 9 by markchang@chromium.org, Jul 10

Status: Fixed (was: Assigned)

Comment 10 by sindhu.chelamcherla@chromium.org, Jul 11

Labels: TE-Verified-M69 TE-Verified-69.0.3488.0
Able to reproduce this issue on reported version hence verifying the fix on latest canary 69.0.3488.0 using Windows 10, Mac 10.13.3 and Debian.

Now observing reflection of user defined on other background tabs.

As fix is working as expected adding TE-Verified labels.

Thanks!
859055_M69.png
176 KB View Download
►

Sign in to add a comment