New issue
Advanced search Search tips

Issue 859048 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Chrome inconsistently switches between UI layout designs based on exit method

Reported by bardi.ha...@gmail.com, Jun 29 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.42 Safari/537.36

Steps to reproduce the problem:
1. Quit Chrome with ⌘Q.
2. Relaunch Chrome.
3. Experience a "comfortable" padded layout.
4. Quit Chrome by selecting quit from the dock right-click menu.
5. Relaunch Chrome.
6. Experience a standard padded layout.

What is the expected behavior?

What went wrong?
The steps to reproduce are somewhat erratic, but in general, the way in which I quit Chrome is causing the browser to switch between the "old" layout and a new layout (Material Design experiment?). In the new layout, the onimbar is not displayed.

Did this work before? N/A 

Chrome version: 68.0.3440.42  Channel: beta
OS Version: OS X 10.13.5
Flash Version: 30.0.0.113
 
old.png
65.2 KB View Download
new.png
70.4 KB View Download

Comment 1 by meh...@chromium.org, Jun 29 2018

Components: -UI Internals>Views>Desktop
Labels: Needs-Feedback Proj-MacViews
Thanks for the report. Can you please record a screencast of the issue and attach it here to the report? Thanks in advance.

Comment 2 by lgrey@chromium.org, Jun 29 2018

Labels: MacViews-Browser
+sdy@ who also mentioned getting MD refresh, then losing it last week.

Comment 3 by lgrey@chromium.org, Jun 29 2018

bardi.harborow@ is this reproducible?
This is very reproducible on my laptop, although I'm starting to doubt the exit method has any bearing on what happens, I think that may have just been a coincidence.
screencapture.mp4
5.8 MB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 30 2018

Cc: meh...@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I should note that when I said "In the new layout, the omnibar is not displayed.", that applies to fullscreen only.

Comment 7 by meh...@chromium.org, Jun 30 2018

Cc: robliao@chromium.org
Status: Untriaged (was: Unconfirmed)
Thanks for your feedback. Yes, I can reproduce it in latest Canary. It seems that Canary is switching between Cocoa and MacViews. Not sure if this is intended.

Repro steps:

- Disable all MacViews-related flags

- Start Chrome
- Result: Canary is in Cocoa Mode

- Quit Chrome (You have to try with CMD-Q or with context-menu of the Dock)
- Start Chrome again
- Result: Chrome is now in MacViews Mode

- Quit Chrome (You have to try with CMD-Q or with context-menu of the Dock)
- Start Chrome again
- Result: Chrome is now in Cocoa Mode

... and so on ...
Yes same thing happening for me on 68.0.3440.42 beta.
This suggests that there may be some strange things going on in metrics/finch. Can you attach your variations from chrome://version for each run when the UI changes from Material Refresh to Cocoa and back?

FYI: Clearing the user profile directory will also have the effect of dropping you out of the experiment as the metrics info needs to be redownloaded and will only apply at the next launch.
robliao@:

Cocoa-Mode variations:

c134752e-efd95b9c
411b6d4e-3f4a17df
fe69e053-94941f92
d01ab0d3-ca7d8d80
16e0dd70-3f4a17df
ebeb14fc-3f4a17df
b7e2524c-f23d1dea
3cd9377c-a3a14831
da89714-f8025c5c
fb88346a-5ecfd4b6
b1681d28-1410f10
9041608a-f23d1dea
afb5d7b8-f23d1dea
9853922b-c200976c
6025934e-3f4a17df
7c1bc906-b5809d46
47e5d3db-3d47f4f4
125b7f68-1a701cf2
d442dfb7-41afa35c
1149accc-f23d1dea
6557d030-6557d030
34d450b1-6b5a1f92
a582a1b8-ad75ce17
495970ba-ca7d8d80
3042ad4b-ca54bb47
ac6e1b9-d93a0620
44827ee5-f23d1dea
d0ecf1da-9ebb8c3a
edbcf7c5-bce43d3
5485fc4d-3f4a17df
9773d3bd-ca7d8d80
93731dca-3d47f4f4
9b4c4257-6ad6e56e
c992f345-4ad60575
9e5c75f1-1bc64d8
f2fd8aaf-ca7d8d80
f79cb77b-3d47f4f4
7a5ba892-f23d1dea
d1cd70a5-43a3984f
4ea303a6-2108e188
6e6e0c7e-ca7d8d80
d92562a9-4d2fac87
74c3667-6194aa9f
2c1d398c-f23d1dea
6973a1cf-3f4a17df
cc54eb06-f23d1dea
ad6d27cc-7075cd8
ff29b1bd-ca7d8d80
da460ac8-f23d1dea
23496387-4ea78229
5a42b5d9-3f4a17df
344833e9-1525b35b
3f273a97-e3ad1896
4bc337ce-69465896
494d8760-52325d43
3ac60855-486e2a9c
f296190c-a2200d3b
4442aae2-6bdfffe7
ed1d377-e1cc0f14
12e17bc5-e1cc0f14
75f0f0a0-a5822863
e2b18481-a5822863
e7e71889-e1cc0f14
f9e5da91-508355f5
6e3b857e-3f4a17df
6a51bb09-6a51bb09
308674c4-ca7d8d80
94e68624-f23d1dea
cc73f8a1-a2d707c6
de384ee6-3d47f4f4
8834fcca-cf4f6ead
81c6897f-3f4a17df
493ac2c5-803f8fc4


MacViews variations:

c134752e-efd95b9c
411b6d4e-3f4a17df
fe69e053-94941f92
d01ab0d3-3a02fa78
16e0dd70-3f4a17df
ebeb14fc-3f4a17df
b7e2524c-f23d1dea
3cd9377c-a3a14831
da89714-4ad60575
fb88346a-5ecfd4b6
b1681d28-1410f10
9041608a-f23d1dea
afb5d7b8-f23d1dea
9853922b-c200976c
6025934e-3f4a17df
7c1bc906-b5809d46
47e5d3db-3d47f4f4
125b7f68-1a701cf2
d442dfb7-41afa35c
1149accc-f23d1dea
6557d030-6557d030
34d450b1-6b5a1f92
a582a1b8-ad75ce17
495970ba-ca7d8d80
3042ad4b-864de28a
ac6e1b9-d93a0620
44827ee5-3f4a17df
d0ecf1da-78740b15
edbcf7c5-bce43d3
5485fc4d-3f4a17df
9773d3bd-ca7d8d80
93731dca-4ea9d0e4
9b4c4257-6ad6e56e
c992f345-4ad60575
9e5c75f1-1bc64d8
f2fd8aaf-b13ae1c7
f79cb77b-3d47f4f4
7a5ba892-f23d1dea
d1cd70a5-43a3984f
4ea303a6-f23d1dea
6e6e0c7e-ca7d8d80
d92562a9-4d2fac87
74c3667-329bdbee
2c1d398c-f23d1dea
6973a1cf-3f4a17df
cc54eb06-3f4a17df
ad6d27cc-7075cd8
ff29b1bd-ca7d8d80
da460ac8-3f4a17df
23496387-232b3cab
5a42b5d9-3f4a17df
344833e9-1525b35b
3f273a97-e3ad1896
4bc337ce-69465896
494d8760-52325d43
3ac60855-486e2a9c
f296190c-a2200d3b
4442aae2-6bdfffe7
ed1d377-e1cc0f14
12e17bc5-e1cc0f14
75f0f0a0-a5822863
e2b18481-a5822863
e7e71889-e1cc0f14
f9e5da91-508355f5
6e3b857e-3f4a17df
6a51bb09-f23d1dea
308674c4-ca7d8d80
94e68624-f23d1dea
cc73f8a1-a2d707c6
de384ee6-3f4a17df
8834fcca-cf4f6ead
81c6897f-f23d1dea
493ac2c5-803f8fc4
Owner: skare@chromium.org
Status: Started (was: Untriaged)
Rob, I think the views study may be configured with session consistency on Mac Canary/Dev. Accepting to track it and will mail or chat with you. Thanks!
...beta too. work in progress.
Status: Fixed (was: Started)
later today, and after restarting, everyone on mac canary/dev/beta should land in one group permanently.
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/384cd44977eff213f058d6893aab116d66663682

commit 384cd44977eff213f058d6893aab116d66663682
Author: Robert Liao <robliao@chromium.org>
Date: Tue Jul 10 00:38:01 2018

Rename ViewsBrowserWindows Enabled to Enabled_20180703

This corresponds with the consistency change from session to permanent.

BUG= 859048 

Change-Id: Ib6f9c977c24d75c74a5b64703610c9020f835bd3
Reviewed-on: https://chromium-review.googlesource.com/1125215
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573556}
[modify] https://crrev.com/384cd44977eff213f058d6893aab116d66663682/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment