New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859045 link

Starred by 1 user
Status: Fixed
Owner:
█ xiaoyinh@chromium.org
Last visit > 30 days ago
Closed: Jul 19
Cc:
ajha@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Non-Regression: In sign-out screen, 'Add person' is seen enabled even though 'Restrict Sign-in..' toggle button is enabled

Project Member Reported by kebalaji@chromium.org, Jun 29 2018 
Chrome Version:69.0.3475.0/10826.0.0 dev channel Peppy,Candy,Blaze
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Navigate to chrome://settings/accounts
(2)Enable 'Restrict Sign-in..' toggle button and Sign-out >> Observe 

Actual: When (Temp)Show web Ui login..button is seen, 'Add person' is seen enabled even though 'Restrict Sign-in..' toggle button is enabled. But when clicked on (Temp)Show web Ui login..button, Add person is seen disabled.

Expected: 'Add Person' should be seen disabled.

This is a Non-Regression issue seen from 68.0.3404.0 ( From the introduction of When (Temp)Show web Ui login..button in Sign-out screen) 

Note: Issue is not seen in Linux,Windows OS

Attached the screencast for reference..
ActualRestrictAddPerson.mp4
9.3 MB View Download

Comment 1 by jdufault@chromium.org, Jun 29 2018

Components: -UI>Browser>Profiles -UI>SignIn UI>Shell>StartScreen
Owner: xiaoyinh@chromium.org
Status: Assigned (was: Untriaged)
FYI: this is a regression because it does not happen on webui login.

Comment 2 by xiaoyinh@chromium.org, Jul 19

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4976046e7410c95da76761a0a5c6fa341eafbe08

commit 4976046e7410c95da76761a0a5c6fa341eafbe08
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Thu Jul 19 23:47:47 2018

Update add user button status when settings changed.

In settings, device owner can configure a list of users which are able
to sign-in to the device,  when all the white-listed users are present in
the device, the add user button on the shelf should be disabled.
This CL updates the add button status when login screen is first shown
and when a user is removed from login screen.

Bug:  859045 
Change-Id: Ib2a9508d8a843ddbefe3447199fa2aca84fb9f39
Reviewed-on: https://chromium-review.googlesource.com/1134432
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576697}
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/ash/login/login_screen_controller.cc
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/ash/login/login_screen_controller.h
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/ash/shelf/login_shelf_view.h
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/chrome/browser/chromeos/login/ui/mock_login_display_host.h
[modify] https://crrev.com/4976046e7410c95da76761a0a5c6fa341eafbe08/chrome/browser/ui/ash/login_screen_client.cc

Comment 4 by xiaoyinh@chromium.org, Jul 19

Status: Fixed (was: Started)
►

Sign in to add a comment