Issue 859043 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	dvadym@chromium.org
Closed:	Jul 2
Cc:	█ nepper@chromium.org
Components:	UI>Browser>Passwords>Generation
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , Chrome , Mac
Pri:	3
Type:	Bug

Password generation is offered when the site is blacklisted.

Project Member Reported by dvadym@chromium.org, Jun 29 2018

Issue description

If the site is blacklisted from saving of passwords, password generation shouldn't be proposed.

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d5d2ef8f7e846feb43e17205ea84683bb0182ca

commit 4d5d2ef8f7e846feb43e17205ea84683bb0182ca
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Fri Jun 29 15:40:38 2018

Do not offer password generation on blacklisted sites.

Bug:859043

Change-Id: I7fe9e257d37e86f27814841eb8173093f847be0c
Reviewed-on: https://chromium-review.googlesource.com/1120183
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571490}
[modify] https://crrev.com/4d5d2ef8f7e846feb43e17205ea84683bb0182ca/components/password_manager/core/browser/password_form_filling.cc
[modify] https://crrev.com/4d5d2ef8f7e846feb43e17205ea84683bb0182ca/components/password_manager/core/browser/password_form_filling_unittest.cc
[modify] https://crrev.com/4d5d2ef8f7e846feb43e17205ea84683bb0182ca/components/password_manager/core/browser/password_form_manager_unittest.cc

Comment 2 by dvadym@chromium.org, Jul 2

Cc: nepper@chromium.org
Summary: Password generation is offered when the site is blacklisted. (was: Password generation offers when the site is blacklisted.)

Comment 3 by dvadym@chromium.org, Jul 2

Status: Fixed (was: Started)

►

Issue 859043 link

Issue metadata

Password generation is offered when the site is blacklisted.

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 29 2018

Comment 1 Deleted

Comment 2 by dvadym@chromium.org, Jul 2

Comment 2 Deleted

Comment 3 by dvadym@chromium.org, Jul 2

Comment 3 Deleted

Sign in to add a comment