Issue metadata
Sign in to add a comment
|
Regression: 'Save identity and Password' text is seen greyed out in Add other WiFi overlay |
||||||||||||||||||||||||
Issue descriptionChrome Version:69.0.3475.0/10826.0.0 dev channel Peppy,Candy,Blaze OS:Chrome OS What steps will reproduce the problem? (1)Recover build>> In Connect to Network overlay, Click on 'Add other WiFi Network' (2)Change the security drop down to 'EAP' and observe the text 'Save identity and Password' Actual: 'Save identity and Password' text is seen greyed out. There is no difference between the 'Allow otger users...' and 'Save identity and Password' Expected: 'Save identity and Password' text should be seen in bold as the toggle button is clickable. There should be some difference between the 'Allow otger users...' and 'Save identity and Password' as There is no difference between the 'Allow other users...' and 'Save identity and Password' can be enabled/disabled. This is a Regression issue as same is working fine in M69 dev Note: Issue is not seen in Linux,Windows OS Attached the screencast for reference..
,
Jun 29 2018
The color change of the toggle labels are due to the change in the body color to use --secondary-text-color (which is redefined from --google-grey-700 to theme color). In the before and after, the text color is the same for both the toggle enabled and disabled states. namratakannan@: Should these toggle labels use --primary-text-color (which will be #212121 here overriding --google-grey-900)? Do we need to have a different label color when the associated toggle control is disabled?
,
Jun 29 2018
,
Jul 2
I discovered an issue with css variable overriding which results in to the wrong color. The colors that should be used for primary and secondary text is --google-grey-900 and --google-grey-700. This is being fixing under https://crbug.com/849857 . I'll restate my questions. What should the label color be for an enabled toggle? Should we have a different color label for the disabled toggle?
,
Jul 2
Including a screenshot of what the toggle labels will look like after the color fix has been merged. The text is darker, but there is no differentiation between the enabled and disabled toggles.
,
Jul 2
The color of the text will be corrected as part of https://crbug.com/849857 . I talked with namratakannan@ offline, and we concluded that the text color of the label does not need to change when the control is disabled. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Jun 29 2018