Non-Regression : Unable to view 'Tab' Focus on 'Connected network with its condition' text in collapsed Uber Tray |
|||||||
Issue descriptionChrome Version: 69.0.3475.0/10827.0.0 dev channel Peppy, Candy & Blaze OS: Chrome What steps will reproduce the problem? (1)Sign into User ->click on Uber Tray ->Now click on 'Collapse menu' icon -> Uber Tray is in collapsed form (2)Now press 'Tab' key until focus is on 'Network' icon -> click on Uber Tray so that Uber Tray gets closed and again click on Uber Tray to open (3)Observe Uber Tray is in collapsed form -> Now press 'Tab' key until focus is on 'Network' icon ->Again press 'Tab' button and observe Focus is not seen anywhere(click on 'Enter' from keyboard and observe list of network section is seen (4)Now again press 'Tab' button -> Observe focus is on 'Bluetooth' option (Please refer Video) Note : Issue is seen for 'Bluetooth' and 'Notifications' text also Expected:After Focus is on 'Network' icon and on pressing 'Tab' Focus should appear on 'Connected network with its condition' text Actual: Instead After Focus is on 'Network' icon and on pressing 'Tab' Focus is not seen anywhere This is Non-Regression Issue as New Uber Tray UI is seen from 69.0.3463.0 @tetsui : please confirm the Issue
,
Jul 9
,
Jul 9
This is caused by not disabling(visible=false) hidden labels when the tray opens initially collapsed. By the same reason, tab focus goes to the invisible brightness/volume sliders. 1. hit [tab] until focus the accessibility button 2. hit [tab] 2 times expected: calendar date is focused actual: no focus seen util hitting [tab] 4 more times
,
Jul 9
> By the same reason, tab focus goes to the invisible brightness/volume sliders. This is not correct. It is not sliders, but the feature pod buttons that are hidden in the collapse mode.
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/567b283b8e2300c28ee39d1db257c5b8cec82edc commit 567b283b8e2300c28ee39d1db257c5b8cec82edc Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Tue Jul 10 09:31:17 2018 Prevent tab focus moved onto invisible button labels. When unified system tray is initially collapsed, button labels are unseen. However those views were updated reflecting collapse state right after opening the tray. Test: manually verified Bug: 859033 Change-Id: I7a2c09e0e454b324476451b216e6d553524273c7 Reviewed-on: https://chromium-review.googlesource.com/1128697 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#573660} [modify] https://crrev.com/567b283b8e2300c28ee39d1db257c5b8cec82edc/ash/system/unified/unified_system_tray_controller.cc
,
Jul 11
The 2nd change has been submitted. ------------------------------------------------ The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83c8148df6fc9b651dfdb90287afdcddd97e6685 commit 83c8148df6fc9b651dfdb90287afdcddd97e6685 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Jul 11 07:06:52 2018 Prevent tab focus moved onto buttons not visible in collapsed mode. Test: manually verified Bug: 858957 Change-Id: I31c2b69ca92680ea38ab38ba65f13169e0e11b45 Reviewed-on: https://chromium-review.googlesource.com/1128822 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574097} [modify] https://crrev.com/83c8148df6fc9b651dfdb90287afdcddd97e6685/ash/system/unified/feature_pods_container_view.cc [modify] https://crrev.com/83c8148df6fc9b651dfdb90287afdcddd97e6685/ash/system/unified/feature_pods_container_view.h ------------------------------------------------ |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tetsui@chromium.org
, Jul 5Owner: yamaguchi@chromium.org