New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859031 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

Chromite unittests failing in all? Pre-CQ runs

Reported by vpalatin@chromium.org, Jun 29 2018

Issue description

All my last CQ runs failed with:
"UnitTest stage failed: Packages failed in /mnt/host/source/chromite/bin/cros_run_unit_tests: chromeos-base/chromite "
the chromite unittests always fail with the same log:
e.g.:
https://luci-logdog.appspot.com/v/?s=chromeos/buildbucket/cr-buildbucket.appspot.com/8942398862993354608/+/steps/UnitTest/0/stdout

I can reproduce locally:
cros_workon-nocturne start chromite
FEATURES=test emerge-nocturne chromite

ends with the same series of errors, e.g
ERROR: [chromite.scripts.cros_portage_upgrade_unittest] MainTest.testFlowStatusReportOneBoard
Test main flow for basic one-board status report.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/host/source/chromite/lib/cros_test_lib.py", line 280, in _stacked_tearDown
    target(obj)
  File "/mnt/host/source/chromite/lib/cros_test_lib.py", line 1558, in tearDown
    self.mox.VerifyAll()
  File "/usr/lib64/python2.7/site-packages/mox.py", line 284, in VerifyAll
    mock_obj._Verify()
  File "/usr/lib64/python2.7/site-packages/mox.py", line 504, in _Verify
    raise ExpectedMethodCallsError(self._expected_calls_queue)
ExpectedMethodCallsError: Verify: Expected methods never called:
  0.  Stub for <unbound method Upgrader.PreRunChecks>.__call__() -> None

and

FAIL: [chromite.scripts.cros_portage_upgrade_unittest] MainTest.testFlowStatusReportOneBoard
Test main flow for basic one-board status report.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/host/source/chromite/lib/timeout_util.py", line 191, in TimeoutWrapper
    return func(*args, **kwargs)
  File "/mnt/host/source/chromite/scripts/cros_portage_upgrade_unittest.py", line 3509, in testFlowStatusReportOneBoard
    'any-package'], expect_zero=True)
  File "/mnt/host/source/chromite/scripts/cros_portage_upgrade_unittest.py", line 3419, in _AssertCPUMain
    'but it exited with code %d' % e.args[0])
AssertionError: expected call to main() to exit cleanly, but it exited with code 1


 
Cc: mikenichols@chromium.org reinauer@chromium.org namyoon@chromium.org yllin@chromium.org
Add sheriffs and CI bobby
By the way all the Paladins are dead with the same error too.
Cc: vapier@chromium.org
525fc9fdb cros_portage_upgrade: kill it for now
seems to be involved in the breakage
from https://chromium-review.googlesource.com/1119417
I'm trying the following as a stop gap:
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1120184 cros_portage_upgrade: disable the unittests
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/e33bdbe1d4a1466d2b4cd66156b4b71c95d5c3d3

commit e33bdbe1d4a1466d2b4cd66156b4b71c95d5c3d3
Author: Vincent Palatin <vpalatin@chromium.org>
Date: Fri Jun 29 15:16:02 2018

cros_portage_upgrade: disable the unittests

While cros_portage_upgrade is temporarily neutered, disable its unittest
to avoid failing the builds.

BUG= chromium:858925   chromium:859031 
TEST=Tryjob

Change-Id: I49641b2b58e95aa41021766017e52e4437daaf53
Reviewed-on: https://chromium-review.googlesource.com/1120184
Trybot-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/e33bdbe1d4a1466d2b4cd66156b4b71c95d5c3d3/cbuildbot/run_tests.py

Status: Fixed (was: Untriaged)
Pre-CQ passed, should be ok now.

Comment 7 by vapier@chromium.org, Jun 29 2018

 Issue 858971  has been merged into this issue.

Comment 8 by vapier@chromium.org, Jun 29 2018

Owner: vpalatin@chromium.org
thanks Vincent
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/845945b6b26062ff8e5e87227244d966adb4872a

commit 845945b6b26062ff8e5e87227244d966adb4872a
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 29 17:38:02 2018

Roll src/third_party/chromite 7869e579e31e..e33bdbe1d4a1 (1 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7869e579e31e..e33bdbe1d4a1


git log 7869e579e31e..e33bdbe1d4a1 --date=short --no-merges --format='%ad %ae %s'
2018-06-29 vpalatin@chromium.org cros_portage_upgrade: disable the unittests


Created with:
  gclient setdep -r src/third_party/chromite@e33bdbe1d4a1

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:858925   chromium:859031 
TBR=chrome-os-gardeners@chromium.org

Change-Id: I52432bf9a3d47ca14da962959bd06cecb9582493
Reviewed-on: https://chromium-review.googlesource.com/1120408
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571513}
[modify] https://crrev.com/845945b6b26062ff8e5e87227244d966adb4872a/DEPS

Cc: minch@chromium.org achuith@chromium.org x...@chromium.org
 Issue 859114  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 14

Labels: merge-merged-stabilize-nocturne.10828.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8fa7c7af66dbb51bd756ee687946fdce777f7749

commit 8fa7c7af66dbb51bd756ee687946fdce777f7749
Author: Vincent Palatin <vpalatin@chromium.org>
Date: Sat Jul 14 04:53:21 2018

cros_portage_upgrade: disable the unittests

While cros_portage_upgrade is temporarily neutered, disable its unittest
to avoid failing the builds.

BUG= chromium:858925   chromium:859031 
TEST=Tryjob

Change-Id: I49641b2b58e95aa41021766017e52e4437daaf53
Reviewed-on: https://chromium-review.googlesource.com/1120184
Trybot-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>
(cherry picked from commit e33bdbe1d4a1466d2b4cd66156b4b71c95d5c3d3)
Reviewed-on: https://chromium-review.googlesource.com/1137753
Reviewed-by: Bob Moragues <moragues@chromium.org>
Commit-Queue: Bob Moragues <moragues@chromium.org>
Tested-by: Bob Moragues <moragues@chromium.org>

[modify] https://crrev.com/8fa7c7af66dbb51bd756ee687946fdce777f7749/cbuildbot/run_tests.py

Sign in to add a comment