Appending URLs from completions doesn't exit preedit. |
|||
Issue descriptionSteps to reproduce: 1. In the omnibox, type a website, e.g. chromium.org and navigate 2. Navigate to another website, e.g. crbug.com 3. Focus omnibox 4. You should now see zero-state suggestions, for example "chromium.org", in the suggestion list. Pick any that is a URL. 5. Click on ↖︎ append query button. Expected results: The fake selection on "crbug.com" disappears and the text in the omnibox is replaced with the chosen suggestion URL, e.g. "chromium.org" Actual results: The fake selection (preedit) is unchanged. The URL is unchanged. It seems like this is caused by the fix for crbug.com/679083 and zero-suggest, as before there was no possibility to append a URL while in pre-edit.
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/228b95b40dc7e9dd77b81bc957911d4d4965e1c5 commit 228b95b40dc7e9dd77b81bc957911d4d4965e1c5 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Wed Jul 04 13:06:10 2018 [iOS] Exit omnibox preedit state on suggestion append. Exits the preedit state upon appending a suggestion. Bug: 859011 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I65809145b1f846157b24e1cc0b74035f235f834f Reviewed-on: https://chromium-review.googlesource.com/1120025 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#572547} [modify] https://crrev.com/228b95b40dc7e9dd77b81bc957911d4d4965e1c5/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
,
Jul 4
,
Jul 10
Verified in 69.0.3487.0 canary in iPhone 7plus(iOS 10.3.3), iPhone 7(iOS 11.4) and iPad Air(iOS 11.4) Followed the steps mentioned in comment#0, the omnibox url is replaced with chosen suggestion URL Link to video: https://drive.google.com/file/d/16Zf-LsO2zZlIjzVOQwkc5IUFIIAWKNfO/view?usp=sharing |
|||
►
Sign in to add a comment |
|||
Comment 1 by marq@chromium.org
, Jul 4