Flaky OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads in browser_tests on Linux ChromiumOS MSan |
|||||
Issue description
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24c45fda13d65cbbf491ce35ed356560c1490bbb commit 24c45fda13d65cbbf491ce35ed356560c1490bbb Author: Henrik Grunell <grunell@chromium.org> Date: Fri Jun 29 11:49:06 2018 Disable flaky OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDownloads on Linux ChromiumOS MSan. TBR=noel@chromium.org Bug: 859008 Change-Id: Icb0689a7390ea62ee5904e9b91d0efee8a478ce6 Reviewed-on: https://chromium-review.googlesource.com/1120026 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571443} [modify] https://crrev.com/24c45fda13d65cbbf491ce35ed356560c1490bbb/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Jun 29 2018
#1 "Spits out lots of" ... what is the elapsed time between the first log output and this test fixture, and the last one you mentioned above "at StepsRunner..."?
,
Jun 29 2018
cc tapted@ due to https://chromium.googlesource.com/chromium/src/+/18b2ef603c8bfa5548c0f8cb03c282e69eddaded
,
Jul 4
Managed to get MSAN going locally, what a trek:
1) install docker, with a Trusty image in same, and a Trusty chrome build.
2) change our Files app test JS to not attempt to load Drive files in test
since they fail in docker (and good luck developer if a flakey MSAN test
involves Files app Drive volumes).
3) Work-around Blink CSSAnimations causing MSAN failures while running browser
tests, an issue that is never seen on the real MSAN bots. Go into the C++
Blink and disable CSSAnimations, cross-fingers.
4) build chrome browser tests in a normal chrome checkout and run them inside
the docker image using the script provoided (see the MSAN docs), and cross-
fingers again and hope that you won't also access chrome devtools to debug
your MSAN issue (that'd need even more docker setup).
Run openAudioDownloads browser test with --single_process to turn off time-outs while running the test ....
,
Jul 4
... test PASS but takes 250 secs in docker. Noted that audioOpenCloseDownloads takes 240 secs and does work well on the MSAN bots. audioOpenDrive also works well on the bots (can't test it in docker, see 2 above) and the only difference between it and audioOpenDownloads is the volume used as the test case code is the same for both. Suggest that the combination of audio/downloads-volume/msan is the root cause of the flakes. One fix might be to make the test on downloads do much less ...
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9071cf2da68030cb442b1328cab7986ed232178b commit 9071cf2da68030cb442b1328cab7986ed232178b Author: Noel Gordon <noel@chromium.org> Date: Wed Jul 04 02:54:27 2018 More OpenAudioFiles/FilesAppBrowserTest speed Make audioOpenClose test case load only the file it needs. Do the same for openAudio test case but further divide into two test cases: single and multiple tracks (today's openAudio is multiple tracks). Do the single track track case on Downloads, and do the multiple track case on Drive because the multiple track case is too slow on Downloads on MSAN/ASAN bots (causing flakes). Drive runs faster on the bots, and already runs the multiple tracks case without problems. Bug: 859008 Change-Id: Ia730d9342e8b8e4c10afbb652a3d666ee8c3ed4c Reviewed-on: https://chromium-review.googlesource.com/1124720 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#572456} [modify] https://crrev.com/9071cf2da68030cb442b1328cab7986ed232178b/ui/file_manager/integration_tests/file_manager/open_audio_files.js
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7b0fb62ccaf99e918999a116d8b91b729ffc088 commit d7b0fb62ccaf99e918999a116d8b91b729ffc088 Author: Noel Gordon <noel@chromium.org> Date: Wed Jul 04 07:36:44 2018 Even more OpenAudioFiles FilesAppBrowserTest speed Shave about 500ms off per test by only loading the file(s) the tests require. Remove getExpectedFileEntryRows helper as a side-effect: it is now unused so git-mv it to /dev/null. Bug: 859008 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id49678e63d2160cbf7ce4daee45d36edaa124b97 Reviewed-on: https://chromium-review.googlesource.com/1125639 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#572506} [modify] https://crrev.com/d7b0fb62ccaf99e918999a116d8b91b729ffc088/ui/file_manager/integration_tests/file_manager/open_audio_files.js
,
Jul 4
,
Jul 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d359350656dfe65f4da2d9a60f98bf8e411d60f3 commit d359350656dfe65f4da2d9a60f98bf8e411d60f3 Author: Noel Gordon <noel@chromium.org> Date: Mon Jul 09 01:20:57 2018 Re-enable FilesAppBrowserTest audioOpenDownloads on MSAN ASAN looking good (no flakes) after crrev.com/572456 crrev.com/572506 (do less, more speed). Now try those on MSAN. Bug: 859008 Change-Id: I0b4209c2776c5d5926cbccb9ef8971ef3afcfd73 Reviewed-on: https://chromium-review.googlesource.com/1127907 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#573195} [modify] https://crrev.com/d359350656dfe65f4da2d9a60f98bf8e411d60f3/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Jul 9
MSAN results looking good [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=OpenAudioFiles%2FFilesApp
,
Jul 9
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by grunell@chromium.org
, Jun 29 2018