New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 858987 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OOO Dec 22 - Jan 8
Closed: Jul 30
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
Audio-Service


Sign in to add a comment

audio::OutputDevice should allow blocking on the main thread.

Project Member Reported by olka@chromium.org, Jun 29 2018

Issue description

When it joins the audio thread.
 
Status: Started (was: Assigned)
Cc: olka@chromium.org
Owner: marinaciocea@chromium.org
Marina, could you land https://chromium-review.googlesource.com/c/chromium/src/+/1119914/10 and add a missing test there?
This fix is needed for ChromeOS work.
Owner: olka@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9acaaa4312f3c35a59a42f0f29742098f5ad3508

commit 9acaaa4312f3c35a59a42f0f29742098f5ad3508
Author: Olga Sharonova <olka@chromium.org>
Date: Wed Jul 25 10:19:36 2018

Allow blocking when audio::OutputDevice joins the audio thread.


BUG= 858987 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic61830a546ffe6873fef4db18a49d03031293fe7
Reviewed-on: https://chromium-review.googlesource.com/1119914
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577832}
[modify] https://crrev.com/9acaaa4312f3c35a59a42f0f29742098f5ad3508/base/threading/thread_restrictions.h
[modify] https://crrev.com/9acaaa4312f3c35a59a42f0f29742098f5ad3508/media/audio/audio_device_thread.h
[modify] https://crrev.com/9acaaa4312f3c35a59a42f0f29742098f5ad3508/services/audio/public/cpp/output_device.cc
[modify] https://crrev.com/9acaaa4312f3c35a59a42f0f29742098f5ad3508/services/audio/public/cpp/output_device.h

Status: Fixed (was: Started)

Sign in to add a comment