policy_templates.json: Make sure examples cover the whole schema |
|||
Issue descriptionAt least every field should show up in the example. Add presubmit check?
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2610da4adc8d07617094bd77a78ac6d702ce24e commit b2610da4adc8d07617094bd77a78ac6d702ce24e Author: Alexander Hendrich <hendrich@chromium.org> Date: Wed Aug 22 17:45:30 2018 Add ValidateValue() to python schema validator This CL adds a method to validate a value against a given schema to the python schema validator. This method is also used in a new presubmit test to ensure all example values are valid in policy_templates.json. Bug: 873641 , 858980 , 856901 Change-Id: I2ad477785e8ee37a9e07ee7231c3d12d8501a43f Reviewed-on: https://chromium-review.googlesource.com/1174443 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#585145} [modify] https://crrev.com/b2610da4adc8d07617094bd77a78ac6d702ce24e/components/policy/core/common/generate_policy_source_unittest.cc [modify] https://crrev.com/b2610da4adc8d07617094bd77a78ac6d702ce24e/components/policy/resources/policy_templates.json [modify] https://crrev.com/b2610da4adc8d07617094bd77a78ac6d702ce24e/components/policy/tools/schema_validator.py [modify] https://crrev.com/b2610da4adc8d07617094bd77a78ac6d702ce24e/components/policy/tools/syntax_check_policy_template_json.py
,
Aug 24
,
Aug 25
is there to verify this fix manually? Thanks
,
Aug 27
@vaandres: sorry no, this is a presubmit check and doesn't need manual verification. |
|||
►
Sign in to add a comment |
|||
Comment 1 by ljusten@chromium.org
, Aug 1Owner: hendrich@chromium.org