New issue
Advanced search Search tips

Issue 858980 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

policy_templates.json: Make sure examples cover the whole schema

Project Member Reported by ljusten@chromium.org, Jun 29 2018

Issue description

At least every field should show up in the example.

Add presubmit check?
 
Cc: ljusten@chromium.org
Owner: hendrich@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2610da4adc8d07617094bd77a78ac6d702ce24e

commit b2610da4adc8d07617094bd77a78ac6d702ce24e
Author: Alexander Hendrich <hendrich@chromium.org>
Date: Wed Aug 22 17:45:30 2018

Add ValidateValue() to python schema validator

This CL adds a method to validate a value against a given schema to the
python schema validator. This method is also used in a new presubmit
test to ensure all example values are valid in policy_templates.json.

Bug:  873641 ,  858980 ,  856901 
Change-Id: I2ad477785e8ee37a9e07ee7231c3d12d8501a43f
Reviewed-on: https://chromium-review.googlesource.com/1174443
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585145}
[modify] https://crrev.com/b2610da4adc8d07617094bd77a78ac6d702ce24e/components/policy/core/common/generate_policy_source_unittest.cc
[modify] https://crrev.com/b2610da4adc8d07617094bd77a78ac6d702ce24e/components/policy/resources/policy_templates.json
[modify] https://crrev.com/b2610da4adc8d07617094bd77a78ac6d702ce24e/components/policy/tools/schema_validator.py
[modify] https://crrev.com/b2610da4adc8d07617094bd77a78ac6d702ce24e/components/policy/tools/syntax_check_policy_template_json.py

Status: Fixed (was: Assigned)
is there to verify this fix manually?

Thanks
Status: Verified (was: Fixed)
@vaandres: sorry no, this is a presubmit check and doesn't need manual verification.

Sign in to add a comment