New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 858957 link

Starred by 2 users
Status: Fixed
Owner:
yamaguchi@chromium.org
Closed: Jul 10
Cc:
tetsui@chromium.org
█ yoshiki@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to view the top part of screenshot even on scrolling when the shelf position is left/right

Project Member Reported by rkalavakuntla@chromium.org, Jun 29 2018 
Chrome Version:69.0.3475.0/10826.0.0 dev channel Peppy,Candy,Blaze
OS:Chrome OS 

What steps will reproduce the problem?
(1)Sign into user >> Set Shelf position to left/right
(2)Take a screenshot >>click at ubertray to view the screenshot on top of ubertray
(3)Now scroll the screenshot and observe unable to view the top part of screenshot even on scroll

Actual: Unable to view the top part of screenshot even on scrolling
Expected: Should be able to view the top part of screenshot even on scrolling

This is a Regression issue as same is working fine in M-68 beta

Note: Issue is not seen in Linux,Windows OS

Attached the screencast for reference..
Actual.mp4
11.1 MB View Download

Comment 1 by tetsui@chromium.org, Jun 29 2018

Cc: -ajha@chromium.org -tetsui@chromium.org yamaguchi@chromium.org yoshiki@chromium.org
Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by tetsui@chromium.org, Jul 5

Cc: -yamaguchi@chromium.org tetsui@chromium.org
Owner: yamaguchi@chromium.org
Yamaguchi-san, could you take a look? Thank you.

Comment 3 by yamaguchi@chromium.org, Jul 10

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e72f7b0aa7a882b75a8f4b1d6b1ce03520ecf80

commit 7e72f7b0aa7a882b75a8f4b1d6b1ce03520ecf80
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Tue Jul 10 10:06:41 2018

Adjust bubble size based on anchor position

Bug:  858957 
Test: manually verified |max_height| in the changed line gives same value as before in the horizontal shelf mode. Also the bubble fits in screen with docked magnifier turned on.
Change-Id: Ia40179b8842f8ececd5f1d0e96e851493b1a378b
Reviewed-on: https://chromium-review.googlesource.com/1131043
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573671}
[modify] https://crrev.com/7e72f7b0aa7a882b75a8f4b1d6b1ce03520ecf80/ash/system/unified/unified_system_tray_bubble.cc

Comment 5 by yamaguchi@chromium.org, Jul 10

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83c8148df6fc9b651dfdb90287afdcddd97e6685

commit 83c8148df6fc9b651dfdb90287afdcddd97e6685
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Wed Jul 11 07:06:52 2018

Prevent tab focus moved onto buttons not visible in collapsed mode.

Test: manually verified
Bug:  858957 
Change-Id: I31c2b69ca92680ea38ab38ba65f13169e0e11b45
Reviewed-on: https://chromium-review.googlesource.com/1128822
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574097}
[modify] https://crrev.com/83c8148df6fc9b651dfdb90287afdcddd97e6685/ash/system/unified/feature_pods_container_view.cc
[modify] https://crrev.com/83c8148df6fc9b651dfdb90287afdcddd97e6685/ash/system/unified/feature_pods_container_view.h

Comment 7 by yamaguchi@chromium.org, Jul 11 

Comment #6 is not relevant to this issue. The bug number linked from the patch was wrong.
►

Sign in to add a comment