New issue
Advanced search Search tips

Issue 858953 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Blank layout displayed for On-screen keyboard with virtual keyboard flag disabled

Project Member Reported by zhan...@chromium.org, Jun 29 2018

Issue description

OS:
69.0.3475.0 Link
10825.0.0 canary link

Steps:
1.Disabled virtual keyboard flag 
2.Keep Floating virtual keyboard enabled
3.Tap emoji, hw ,voice icon from task menu list 
4.Enabled On-screen keyboard in Accessibility 
5.Click Input tool icon from right-down corner

Actual:
3.1 Keyboard can not be opened, have no response 
5.1 Black keyboard area will displayed; 

refers to attached video

 
Jun 29 2018 2_45 PM.webm
2.5 MB View Download
Jun 29 2018 2_50 PM.webm
1.3 MB View Download
Still repro in 69.0.3479.0 
10836.0.0 canary link
Google input tools version: 69.0.5.0
Cc: wuyingbing@chromium.org
Owner: shend@chromium.org
I can take a look
Seems like something wrong with the keyset override URLs. This is a bug for both old UI (regression) and new UI. On old UI, we observe the behaviour as described previously. On new UI, the emoji layout launched by the ime tray menu is completely broken.
Note this is specifically for the accessibility keyboard in floating mode.
My guess: When we force launch the floating keyboard,

1. virtual keyboard is showing
2. the IME extension will change the container type to floating
3. virtual keyboard will hide
4. virtual keyboard thinks the user is done using the temporary keyboard, so we disable the accessibility keyboard
5. virtual keyboard cannot open again coz it's disabled.

To fix it, we either have to always launch the temporary keyboard in docked mode, or make OnKeyboardHidden understand that the hide is only temporary, so don't disable the keyboard.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb5851b2be2d366f9bacc6befadbdd378c007967

commit bb5851b2be2d366f9bacc6befadbdd378c007967
Author: Darren Shen <shend@chromium.org>
Date: Thu Jul 19 07:04:06 2018

[VK] Don't disable keyboard in IME tray due to temporary hide.

When we use the IME menu tray in laptop mode, we temporarily enable the
accessibility virtual keyboard. When the keyboard is dismissed, we
disable the accessibility keyboard again. However, when we change the
keyboard between docked and floating mode, the keyboard has to hide
first before showing again. This causes the accessibility keyboard to be
disabled and the keyboard doesn't show up again.

We fix this by adding an additional parameter to OnKeyboardHidden
which indicates whether the keyboard is hidden temporarily.

TBR=sky@chromium.org

Bug:  858953 
Change-Id: I162917e5e32e6081be49127a3e7e9cf5fbeeb11c
Reviewed-on: https://chromium-review.googlesource.com/1137803
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576400}
[modify] https://crrev.com/bb5851b2be2d366f9bacc6befadbdd378c007967/ash/keyboard/virtual_keyboard_controller.cc
[modify] https://crrev.com/bb5851b2be2d366f9bacc6befadbdd378c007967/ash/keyboard/virtual_keyboard_controller.h
[modify] https://crrev.com/bb5851b2be2d366f9bacc6befadbdd378c007967/ash/keyboard/virtual_keyboard_controller_unittest.cc
[modify] https://crrev.com/bb5851b2be2d366f9bacc6befadbdd378c007967/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/bb5851b2be2d366f9bacc6befadbdd378c007967/ash/system/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/bb5851b2be2d366f9bacc6befadbdd378c007967/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/bb5851b2be2d366f9bacc6befadbdd378c007967/ui/keyboard/keyboard_controller_observer.h

Status: Fixed (was: Assigned)
Should be fixed now.
Not repro in  70.0.3511.0 ,10945.0.0 canary-channel bob
Input tools version:
9999.0.20180802.207109309

Need to confirm in Link 

Sign in to add a comment