New issue
Advanced search Search tips

Issue 858952 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : First few Pdf pages are seen blank in print preview.

Reported by pranjali...@etouch.net, Jun 29 2018

Issue description

Chrome version : 69.0.3476.0 (Official Build) 86d261c5d8d1e6cd27cd72f8887c8de670f11b48-refs/branch-heads/3476@{#1}(32/64-bit) 

OS : Win(7,8,8.1,10) OS

Test URL: http://cb.vu/unixtoolbox.pdf

Steps to reproduce:
1. Launch chrome and navigate to above test url.
2. Now click on print icon on pdf and observe.

Actual Result: First few Pdf pages are seen blank in print preview.
Expected Result: Pdf pages should not be seen blank in print preview.

This is a regression issue broken in ‘M-69’ and will soon update other bisect info.
Good build: 69.0.3475.0 
Bad build: 69.0.3476.0 
 
Actual_result.mp4
366 KB View Download
Can you check if r571206 caused this?
Cc: art-sn...@yandex-team.ru
Looks like yes. https://pdfium.googlesource.com/pdfium/+/35ab1bd0328a244cc2f6dcde2822c8117738b01d

I will revert.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/20c3677acc37c959034d6111c0cab2e681b13717

commit 20c3677acc37c959034d6111c0cab2e681b13717
Author: Lei Zhang <thestig@chromium.org>
Date: Fri Jun 29 06:55:50 2018

Revert "Simplify CPDF_PageOrganizer::UpdateReference method."

This reverts commit 35ab1bd0328a244cc2f6dcde2822c8117738b01d.

Reason for revert: Causing crashes and bad flattening.

BUG= chromium:858921 , chromium:858952 

Original change's description:
> Simplify CPDF_PageOrganizer::UpdateReference method.
> 
> Change-Id: I52fe66472bdc2a61d7074f77627a3ee1d5646255
> Reviewed-on: https://pdfium-review.googlesource.com/35611
> Reviewed-by: dsinclair <dsinclair@chromium.org>
> Commit-Queue: Art Snake <art-snake@yandex-team.ru>

TBR=dsinclair@chromium.org,art-snake@yandex-team.ru

Change-Id: I9a3635140867793e7109c15b64d66ec1d1a8b1f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/36550
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/20c3677acc37c959034d6111c0cab2e681b13717/fpdfsdk/fpdf_ppo.cpp

Status: Fixed (was: Unconfirmed)
Let's test 69.0.3477.0 tomorrow and make sure this is fixed.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/263717da77837a30a6094b289d2aaaf5e3845f00

commit 263717da77837a30a6094b289d2aaaf5e3845f00
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 29 09:14:24 2018

Roll src/third_party/pdfium 5fbb98122c59..20c3677acc37 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/5fbb98122c59..20c3677acc37


git log 5fbb98122c59..20c3677acc37 --date=short --no-merges --format='%ad %ae %s'
2018-06-29 thestig@chromium.org Revert "Simplify CPDF_PageOrganizer::UpdateReference method."


Created with:
  gclient setdep -r src/third_party/pdfium@20c3677acc37

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:858921 , chromium:858952 
TBR=dsinclair@chromium.org

Change-Id: Idb479ee7ece0b0393389cbc86fe1a187b091207e
Reviewed-on: https://chromium-review.googlesource.com/1119710
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571433}
[modify] https://crrev.com/263717da77837a30a6094b289d2aaaf5e3845f00/DEPS

Labels: TE-Verified-69.0.3479.0 TE-Verified-M69
Update:

Rechecked above issue on Win(7,8,8.1,10) OS using latest canary build #69.0.3479.0 and issue is fixed. All PDF pages are seen on print preview.

Please refer attached screen cast for reference.

Thank You.
Canary_behaviour.mp4
666 KB View Download

Sign in to add a comment