New issue
Advanced search Search tips

Issue 858951 link

Starred by 2 users
Status: Fixed
Owner:
wutao@chromium.org
Closed: Jun 2018
Cc:
nyerramilli@chromium.org
msw@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus stays on 'Allowed' section of 'cookies in use' overlay even after hitting right arrow key.

Reported by vku...@etouch.net, Jun 29 2018 
Chrome Version: 69.0.3476.0 (Official Build) Revision 86d261c5d8d1e6cd27cd72f8887c8de670f11b48-refs/branch-heads/3476@{#1} (32/64-bit)
OS:Windows(7,8,8.1,10) & Linux(14.04 LTS).

What steps will reproduce the problem?
(1)Launch chrome and navigate to any webpage 
(2)Click on 'view site information' > cookies, press 'tab' key such that focus appears on 'Allowed'
(3)Now press right arrow key such that focus reaches on 'Blocked' section,observe

Actual: Focus stays on 'Allowed' section of 'cookies in use' overlay even after hitting right arrow key.

Expected: Focus should appear on 'Blocked section of 'cookies in use' overlay after hitting right arrow key.

This is a regression issue broken in 'M69' and below is the manual regression range
Good Build: 69.0.3472.3(Revision:569949)
Bad Build:  69.0.3473.0(Revision:570288)
Actual_highlight.png
533 KB View Download

Comment 1 by vku...@etouch.net, Jun 29 2018

Labels: hasbisect-per-revision RegressedIn-69 Target-69 FoundIn-69 OS-Mac
Owner: wutao@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 570284 (known good), but no later than 570285 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/765bd7495102533c9d18516ed164f535182e9839..d8b6beee351f6c9b2777b46b1f367ec04d844e3c

Suspect: https://chromium.googlesource.com/chromium/src/+/d8b6beee351f6c9b2777b46b1f367ec04d844e3c

@wutao: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Actual_Cookie.mp4
658 KB View Download
Expected_Cookie.mp4
506 KB View Download

Comment 2 by wutao@chromium.org, Jun 29 2018

Cc: msw@chromium.org
Labels: OS-Chrome
+msw@

Put out a fix to: https://crrev.com/c/1120682
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/477fb82e57b9df5ca1c41d23756f48174ac724ee

commit 477fb82e57b9df5ca1c41d23756f48174ac724ee
Author: wutao <wutao@chromium.org>
Date: Fri Jun 29 19:36:09 2018

TabbedPane: Fix MdTab::OnBlur

This cl fixes a logic in OnBlur in MdTab. If it is not kHighlight,
the focus ring should be cleared.

Bug:  858951 
Test: manual.
Change-Id: I0799ad506ce71e1a77de6be0332523cffad5959d
Reviewed-on: https://chromium-review.googlesource.com/1120682
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571594}
[modify] https://crrev.com/477fb82e57b9df5ca1c41d23756f48174ac724ee/ui/views/controls/tabbed_pane/tabbed_pane.cc

Comment 4 by wutao@chromium.org, Jun 29 2018

Status: Fixed (was: Assigned)

Comment 5 by sanyam.g...@etouch.net, Jul 2

Labels: TE-Verified-69.0.3479.0 TE-Verified-M69
Update:-

Re-tested this issue on Win(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.6) and Linux(14.04 LTS)OS using latest Chrome Canary build# 69.0.3479.0 and issue is fixed. Hence adding TE-Verified labels. 

Please find the attached screen-cast for reference.

Thanks..!
Actual.mp4
1.0 MB View Download
►

Sign in to add a comment