New issue
Advanced search Search tips

Issue 858935 link

Starred by 3 users
Status: Fixed
Owner:
lucmult@chromium.org
Closed: Sep 14
Cc:
fukino@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 835203



Sign in to add a comment

Convert FakeEntry to FilesAppEntry type

Project Member Reported by lucmult@chromium.org, Jun 29 2018 
Currently FakeEntry is just a plain JS object (dict-like) with Closure typedef, as part of crbug.com/835203 (custom classes for Entries) we should migrate FakeEntry to be a FilesAppEntry.

Additionally we should make clear what is a FakeEntry, because historically any entry-like thing that wasn't the native Entry/DirectoryEntry was considered FakeEntry, however with the new types based on FilesAppEntry this distinction isn't clear anymore.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5cf2d154a3be69b29211da09b15724f9215bf15

commit d5cf2d154a3be69b29211da09b15724f9215bf15
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Sep 14 00:51:58 2018

Convert FakeEntry to a class

Being a class makes it a stronger type and more convenient to use.

FakeEntry implements the base interface FilesAppEntry.

Replace most of closure markups for FakeEntry to use FilesAppEntry,
since FakeEntry now implements FilesAppEntry.

Updated a few other closure markups as pointed by closure compiler.

Include files_app_entry_types.js to files that refer to FakeEntry as
pointed by failing tests.

No change in logic.

Test: Unit test for FakeEntries attributes and methods.
Bug:  858935 
Change-Id: I45f80c8a83531c76de8bcac6531071115492d3db
Reviewed-on: https://chromium-review.googlesource.com/1212207
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591240}
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/externs/command_handler_deps.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/externs/volume_info_list.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/externs/volume_manager.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/background/js/device_handler_unittest.html
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/background/js/mock_volume_manager.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/background/js/volume_info_impl.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/background/js/volume_manager_impl.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/background/js/volume_manager_unittest.html
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/common/js/files_app_entry_types.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/common/js/importer_common.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/common/js/importer_common_unittest.html
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/common/js/volume_manager_common.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/directory_contents.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/import_controller.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/ui/location_line.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js
[modify] https://crrev.com/d5cf2d154a3be69b29211da09b15724f9215bf15/ui/file_manager/file_manager/test/scripts/create_test_main.py

Comment 3 by lucmult@google.com, Sep 14

Cc: -sashab@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment