Time to roll a new compiler according to mage rotation. We are going to pick the compiler according to this Google3 CL: https://critique.corp.google.com/#review/199724125
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c7333df11f788c834d164dc7f418ce7303f36f4b commit c7333df11f788c834d164dc7f418ce7303f36f4b Author: Luis A. Lozano <llozano@google.com> Date: Fri Jul 06 14:53:55 2018 LLVM: Change llvm-next to version 333878 In preparation for LLVM roll to 333878, modify llvm-next. CQ-DEPEND=CL:912448 BUG=chromium:858896 TEST=llvm-next builds. Change-Id: Ic1f8481e7a8c2295eb5527e896abd4b14233347f Reviewed-on: https://chromium-review.googlesource.com/1119571 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [rename] https://crrev.com/c7333df11f788c834d164dc7f418ce7303f36f4b/sys-devel/lld/lld-7.0_pre331547-r1.ebuild [rename] https://crrev.com/c7333df11f788c834d164dc7f418ce7303f36f4b/sys-libs/compiler-rt/compiler-rt-7.0_pre331547-r1.ebuild [rename] https://crrev.com/c7333df11f788c834d164dc7f418ce7303f36f4b/sys-devel/llvm/llvm-7.0_pre331547_p20180529-r5.ebuild [add] https://crrev.com/c7333df11f788c834d164dc7f418ce7303f36f4b/sys-devel/llvm/files/clang-7.0-flto-fission.llvm-next.patch
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1a945e6162df008887f74758e805d283af379dda commit 1a945e6162df008887f74758e805d283af379dda Author: Manoj Gupta <manojgupta@google.com> Date: Fri Jul 06 14:53:56 2018 libcxx/libcxxabi: Update to use latest aosp versions for llvm-next. Update libc++ and libc++abi to current aosp trunk r334917 for llvm-next. Does not change the current libc++ in Chrome OS. BUG=chromium:858896 BUG= chromium:856904 TEST=llvm-next builds. CQ-DEPEND=CL:1119571 Change-Id: Ibbfa6a3d7545d015d60fd6f8f376ed8618d9b525 Reviewed-on: https://chromium-review.googlesource.com/912448 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org> [add] https://crrev.com/1a945e6162df008887f74758e805d283af379dda/sys-libs/libcxxabi/files/libcxxabi-7-use-libgcc_eh.patch [add] https://crrev.com/1a945e6162df008887f74758e805d283af379dda/sys-libs/libcxx/files/libcxx-7-use-libgcc_eh.patch [rename] https://crrev.com/1a945e6162df008887f74758e805d283af379dda/sys-libs/libcxx/libcxx-4.0.0-r14.ebuild [delete] https://crrev.com/c7333df11f788c834d164dc7f418ce7303f36f4b/sys-libs/libcxxabi/libcxxabi-9999.ebuild [rename] https://crrev.com/1a945e6162df008887f74758e805d283af379dda/sys-libs/libcxxabi/libcxxabi-4.0.0-r35.ebuild
correctness testing is going well. only 2 remaining things to verify. performance testing is still going on. See blocking bug. testing matrix: https://docs.google.com/spreadsheets/d/1wca9iIEzv59WY87D_ndRpjIPtTw8gCxh7-xb_mrc-PI/edit#gid=0
After some reruns, correctness testing did not find any issues.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5b1c8bff1b83bfd9b4ca2c878e0c73271c430289 commit 5b1c8bff1b83bfd9b4ca2c878e0c73271c430289 Author: Luis A. Lozano <llozano@google.com> Date: Thu Aug 09 19:21:51 2018 [llvm]: roll to version r333878 Testing is captured in https://docs.google.com/spreadsheets/d/1wca9iIEzv59WY87D_ndRpjIPtTw8gCxh7-xb_mrc-PI/edit#gid=0 BUG=chromium:858896, chromium:840971 TEST=See testing matrix. Change-Id: Id609cc92d632d3c1fefff70041076796df95c8c6 Reviewed-on: https://chromium-review.googlesource.com/1168987 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Manoj Gupta <manojgupta@chromium.org> Trybot-Ready: Luis Lozano <llozano@chromium.org> Commit-Queue: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-devel/llvm/files/cherry/1b2e8fb0ce651da2d47b98c33b29c0f42a080f13.patch [rename] https://crrev.com/5b1c8bff1b83bfd9b4ca2c878e0c73271c430289/sys-libs/libcxxabi/libcxxabi-7.0.0-r1.ebuild [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-libs/libcxx/files/libcxx-4.0-xlocale.patch [rename] https://crrev.com/5b1c8bff1b83bfd9b4ca2c878e0c73271c430289/sys-libs/llvm-libunwind/llvm-libunwind-7.0_pre333878-r1.ebuild [rename] https://crrev.com/5b1c8bff1b83bfd9b4ca2c878e0c73271c430289/sys-libs/compiler-rt/compiler-rt-7.0_pre333878-r1.ebuild [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-devel/llvm/files/cherry/d5ae6a3f71cbd25e2367c56e1d452bcff16c8324.patch [rename] https://crrev.com/5b1c8bff1b83bfd9b4ca2c878e0c73271c430289/sys-libs/libcxx/libcxx-7.0.0-r1.ebuild [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-libs/libcxxabi/files/libcxxabi-use-libgcc_eh.patch [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-devel/llvm/files/llvm-7.0-dwo-name.patch [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-devel/llvm/files/cherry/b25fd2f921ce952213dcf1ac047150996c1d15c2.patch [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-devel/llvm/files/cherry/ff5baa90d1d3b92c0cffb3a7b1060088d8dcf82b.patch [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-devel/llvm/files/cherry/44b4b3a25821d2024d98417752844a0809ecd204.patch [rename] https://crrev.com/5b1c8bff1b83bfd9b4ca2c878e0c73271c430289/sys-devel/clang/clang-7.0_pre333878_p20180808-r1.ebuild [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-libs/libcxx/files/libcxx-use-libgcc_eh.patch [rename] https://crrev.com/5b1c8bff1b83bfd9b4ca2c878e0c73271c430289/sys-devel/lld/lld-7.0_pre333878-r1.ebuild [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-libs/compiler-rt/files/cherry/1b2e8fb0ce651da2d47b98c33b29c0f42a080f13.patch [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-devel/llvm/files/clang-7.0-flto-objcopy.patch [rename] https://crrev.com/5b1c8bff1b83bfd9b4ca2c878e0c73271c430289/sys-devel/llvm/llvm-7.0_pre333878_p20180808-r1.ebuild [delete] https://crrev.com/0840f132079900415f1e2e3d8bd3f7f5eea6dd43/sys-devel/llvm/files/cherry/23ea169fe0e4316bf621c6a690900c8a7d9f8707.patch
This has caused a problem in existing chroots. see Issue 873201
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/98d4b8559aab43cb601f1e912cff4371856875ff commit 98d4b8559aab43cb601f1e912cff4371856875ff Author: Luis A. Lozano <llozano@google.com> Date: Sat Aug 11 05:43:56 2018 generic_stages: temporarily ignore all target prebuilts. Ignore the target prebuilts and rebuild packages from source. This is a temporary CL. Revert this CL once in has participated in a green CQ run. This process is documented at: https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries BUG=chromium:858896 TEST='./cbuildbot/run_tests' passed. Change-Id: Ied15ce70cdb283d85088062698aa5d037b6e4079 Reviewed-on: https://chromium-review.googlesource.com/1171249 Commit-Ready: Luis Lozano <llozano@chromium.org> Tested-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Gregory Meinke <gmeinke@chromium.org> [modify] https://crrev.com/98d4b8559aab43cb601f1e912cff4371856875ff/lib/sysroot_lib.py [modify] https://crrev.com/98d4b8559aab43cb601f1e912cff4371856875ff/cbuildbot/stages/build_stages_unittest.py [modify] https://crrev.com/98d4b8559aab43cb601f1e912cff4371856875ff/cbuildbot/stages/generic_stages.py [modify] https://crrev.com/98d4b8559aab43cb601f1e912cff4371856875ff/lib/config_lib.py [modify] https://crrev.com/98d4b8559aab43cb601f1e912cff4371856875ff/config/config_dump.json
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/62dc9deeea75fba1cb5087d8447177baf71f19f0 commit 62dc9deeea75fba1cb5087d8447177baf71f19f0 Author: Manoj Gupta <manojgupta@chromium.org> Date: Sat Aug 11 06:01:37 2018 Revert "generic_stages: temporarily ignore all target prebuilts." Reason for revert: master-paladin had a green run and uploaded new prebuilts. Original change's description: > generic_stages: temporarily ignore all target prebuilts. > > Ignore the target prebuilts and rebuild packages from source. > > This is a temporary CL. Revert this CL once in has participated in > a green CQ run. This process is documented at: > > https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries > > BUG=chromium:858896 > TEST='./cbuildbot/run_tests' passed. > > Change-Id: Ied15ce70cdb283d85088062698aa5d037b6e4079 > Reviewed-on: https://chromium-review.googlesource.com/1171249 > Commit-Ready: Luis Lozano <llozano@chromium.org> > Tested-by: Luis Lozano <llozano@chromium.org> > Reviewed-by: Gregory Meinke <gmeinke@chromium.org> Bug: chromium:858896 Change-Id: I5882b81f4b440fee4a3678ea296fd8989cb48070 Reviewed-on: https://chromium-review.googlesource.com/1172022 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/62dc9deeea75fba1cb5087d8447177baf71f19f0/lib/sysroot_lib.py [modify] https://crrev.com/62dc9deeea75fba1cb5087d8447177baf71f19f0/cbuildbot/stages/build_stages_unittest.py [modify] https://crrev.com/62dc9deeea75fba1cb5087d8447177baf71f19f0/cbuildbot/stages/generic_stages.py [modify] https://crrev.com/62dc9deeea75fba1cb5087d8447177baf71f19f0/lib/config_lib.py [modify] https://crrev.com/62dc9deeea75fba1cb5087d8447177baf71f19f0/config/config_dump.json
Two days after the roll, I am reviewing the release builders: - lakitu-gpu-release has been failing since the same day of the roll in "signertest". However, the failure pattern started just before the roll. The roll became effective on August 10 at 8 AM. The failed builder started failing just before that. https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8938587095639257408 - Same thing with lakitu-release - And with octopus-release. - Filed Issue 873552 for this problem. - Peach-pi-release has been mostly red since the roll, but the first builder after the roll is green. https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8938557387000901552 So, it looks like there are no new problems introduce by the roll (from what we see in the release builder testing).
Comment 1 by llozano@chromium.org
, Jul 3