thread_times and rendering metrics stopped working |
|||
Issue descriptionIt seems something broke with frame detection on today's Canary which has made thread_times benchmark results flatline. Here are some of the affected benchmarks: https://chromeperf.appspot.com/report?sid=f5b0a8ff79b779f3fec3336bdeaeec6feb80533d7de6cca364fb3f71992edb6c
,
Jun 29 2018
When running locally, all *_per_frame* metrics are showing up as zero, the rest look OK. Looking into it more.
,
Jun 29 2018
OK, looks like my fault: the removal of this trace-event is causing this: https://chromium-review.googlesource.com/c/chromium/src/+/1116345/6/cc/trees/layer_tree_host_impl.cc#b2017
,
Jun 29 2018
The fix is in CQ: https://chromium-review.googlesource.com/c/chromium/src/+/1119625
,
Jun 29 2018
Thanks @sadrul! We have monitoring on some of these AFAIK, however I was checking if there were related perf alerts and didn't notice any.
,
Jun 29 2018
I forgot to include the bug# for this one in the fix, so the message wasn't posted here, but the fix has landed. amyqiu@ any ideas why the alerts may not have fired?
,
Jun 29 2018
I'm not sure why the alerts didn't fire for thread_times.tough_compositor_cases, I haven't changed any of the alerts yet
,
Aug 16
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sadrul@chromium.org
, Jun 29 2018