New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 858888 link

Starred by 3 users
Status: Fixed
Owner:
█ cfindeisen@chromium.org
Last visit > 30 days ago
Closed: Jul 9
Cc:
█ s...@chromium.org
█ szym@chromium.org
tbansal@chromium.org
█ bcf@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Fatal DCHECK during wifi setup operation

Project Member Reported by cfindeisen@chromium.org, Jun 29 2018 
OS: CastOs

Occasionally seeing DCHECK failing during wifi operation, especially in QA tests.

FATAL:network_metrics_provider.cc(248)] Check failed: network_change_notifier_initialized_ || connection_type_ == net::NetworkChangeNotifier::CONNECTION_UNKNOWN. 


Currently this is the thought of root cause: 
If the connection is updated and ProvideSystemProfileMetrics is called before OnConnectionTypeChanged is called, connection_type_ will be updated and network_change_notifier_initialized_ will not be, causing the subsequent DCHECK failure.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/339c012e89e3a2f86c3818afb199da24f754552c

commit 339c012e89e3a2f86c3818afb199da24f754552c
Author: Chris Findeisen <cfindeisen@chromium.org>
Date: Fri Jun 29 22:24:17 2018

Update network_initialized when connection_type changes

Elsewhere, when connection_type_ is updated,
network_change_notifier_initialized is set to true if the connection
type is not UNKNOWN.

Bug:  858888 
Test: Tested that DCHECK is no longer failing.
Change-Id: Ifae977543e22a6eef07ea20f85a8ba92087845b2
Reviewed-on: https://chromium-review.googlesource.com/1119544
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571677}
[modify] https://crrev.com/339c012e89e3a2f86c3818afb199da24f754552c/components/metrics/net/network_metrics_provider.cc

Comment 2 by cfindeisen@chromium.org, Jul 9

Status: Fixed (was: Started)
►

Sign in to add a comment