"CloudPolicyTest.InvalidatePolicy" is flaky |
|||
Issue description"CloudPolicyTest.InvalidatePolicy" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBDbG91ZFBvbGljeVRlc3QuSW52YWxpZGF0ZVBvbGljeQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs This flaky test/step was previously tracked in issue 722246 .
,
Jun 29 2018
,
Jun 29 2018
I've been looking at this for the last few hours. I believe my cl is changing the timing to expose some race conditions in the test policy test server. I have a workaround that I'm testing now.
,
Jun 29 2018
fyi fix is in the cq https://chromium-review.googlesource.com/c/chromium/src/+/1119628
,
Jun 29 2018
Issue 858840 has been merged into this issue.
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a492861946fe396c4cf9b02d23ee101f7665096 commit 7a492861946fe396c4cf9b02d23ee101f7665096 Author: John Abd-El-Malek <jam@chromium.org> Date: Fri Jun 29 06:01:33 2018 Fix flake in some CloudPolicyTest tests after SimpleURLLoader conversion in r571184. There was a race condition when the policy fetch request that's initiated in CloudPolicyTest::SetUpOnMainThread is cancelled becauase the test bodies start their own request (through RefreshPolicies). The first request seems to get the python test server in a bad state and it stops responding to requests afterwards. The fix is to skip issuing the first request by temporarily unregistering CloudPolicyRefreshScheduler. TBR=pmarko Bug: 858883 Change-Id: I8c158ab3dffc2f38a7712a6806f9b8d28efbcfdb Reviewed-on: https://chromium-review.googlesource.com/1119628 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#571402} [modify] https://crrev.com/7a492861946fe396c4cf9b02d23ee101f7665096/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
,
Jun 29 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jam@chromium.org
, Jun 29 2018Status: Started (was: Untriaged)