New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 858880 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Settings: Runtime error thrown when exiting new autofill subpages.

Project Member Reported by dpa...@chromium.org, Jun 29 2018

Issue description

Repro steps:
1) Under people section, find new "Payments" subpage.
2) Enter and exit the subpage.
3) Observe that the focus is not correct after exiting the subpage (arrow icon should be focused). Runtime error in the console, see attachment.
 
runtime_error.png
105 KB View Download

Comment 1 by dpa...@chromium.org, Jun 29 2018

Cc: steve...@chromium.org
Seems to have been introduced at r571079.
Cc: jdoerrie@chromium.org
Owner: ----
Status: Available (was: Assigned)
While I have changed the settings page recently, I don't think it is my change that is responsible. I am able to reproduce this with the "Chromium name and picture" subpage in r571078 as well. See the attached screenshot.



4kRuXNu6sUf.png
155 KB View Download
Owner: scottchen@chromium.org
Status: Assigned (was: Available)
Able to reproduce this on old builds as well when forcing diceEnabled_ to be true. Assigning to scottchen@ to investigate further.
Cc: -jdoerrie@chromium.org scottchen@chromium.org
Owner: jdoerrie@chromium.org
Apologies for the churn here. While "Chromium name and picture" does suffer from a similar issue, my change did in fact introduce the same issue. From my current understanding this is because of introducing a new shadow-root, for which the used querySelector '#passwordManagerButton .subpage-arrow' is not sufficient. Changing it to '#passwordManagerButton /deep/ .subpage-arrow' seems to fix the issue. https://crrev.com/c/1122616 implements the change.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fe015851ebc02d18736490caf5db3e42f29884e

commit 4fe015851ebc02d18736490caf5db3e42f29884e
Author: dpapad <dpapad@chromium.org>
Date: Fri Jul 06 18:40:27 2018

Settings WebUI: Fix cr-link-row focus() to focus the icon.

This was broken when cr-link-row was converted to a <button> wrapper at r544912.
Also fixing related runtime error thrown by the newly added cr-link-row instances
in people_page.html.

Bug:  859983 , 858880 
Change-Id: I277d02a8a356a36d1ac64e18019f65c3f904c9c3
Reviewed-on: https://chromium-review.googlesource.com/1125089
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573025}
[modify] https://crrev.com/4fe015851ebc02d18736490caf5db3e42f29884e/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/4fe015851ebc02d18736490caf5db3e42f29884e/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.js

Cc: jdoerrie@chromium.org
Owner: dpa...@chromium.org
Status: Fixed (was: Assigned)
Labels: TE-Verified-69.0.3486.0 TE-Verified-M69
Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 17.10 on the build without fix 69.0.3480.0 and the issue is fixed on the latest Canary 69.0.3486.0 as per the original comment.

Cannot find any runtime error in Console on navigating to "Payments" page and exiting the page.
Also the focus is correct on exiting the Payments page and on hitting the tab key.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
858880-M69.mp4
672 KB View Download

Sign in to add a comment