New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 858869 link

Starred by 2 users
Status: Fixed
Owner:
martiniss@chromium.org
Closed: Jul 12
Cc:
serg...@chromium.org
█ kbr@chromium.org
machenb...@chromium.org
dpranke@chromium.org
jbudorick@chromium.org
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove distinction between post_run and run in chromium_tests/steps.py

Project Member Reported by martiniss@chromium.org, Jun 28 2018 
I was looking through chromium_tests/steps.py and I noticed that there seems to be no test which uses both run and post_run. They all seem to use only one of them.

(I looked at internal bots and didn't see this anywhere)

I think we should just get rid of post_run, and only have pre_run and run. I'm going to make a CL to do this. Any thoughts?

Comment 1 by martiniss@chromium.org, Jun 29 2018

Cc: machenb...@chromium.org serg...@chromium.org
I just took a look at the v8 recipe modules. It looks like they might use pre_run, run, and post_run in the same test. It's a bit hard to tell.

They aren't using test_utils, though (they import it but never use it, AFAIK), so I don't think it matters if we remove it from the chromium_tests code.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c7429ab7ffaaf5ad0de2c80ebdaedf9a1f90bf20

commit c7429ab7ffaaf5ad0de2c80ebdaedf9a1f90bf20
Author: Stephen Martinis <martiniss@chromium.org>
Date: Mon Jul 02 18:57:11 2018

Fix webrtc passing around non api

Webrtc was passing an actual object when it should have been passing a
collection of modules. This CL fixes this.

Bug:  858869 
Change-Id: If741b17c26cb5befde1de111655508e10434768d
Reviewed-on: https://chromium-review.googlesource.com/1119539
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/c7429ab7ffaaf5ad0de2c80ebdaedf9a1f90bf20/scripts/slave/README.recipes.md
[modify] https://crrev.com/c7429ab7ffaaf5ad0de2c80ebdaedf9a1f90bf20/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/c7429ab7ffaaf5ad0de2c80ebdaedf9a1f90bf20/scripts/slave/recipe_modules/webrtc/steps.py

Comment 3 by machenb...@chromium.org, Jul 3 

V8's code should be independent of chromium_tests. The concept was copied at some point.

Comment 4 by martiniss@chromium.org, Jul 9

Owner: martiniss@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b85487654c37ae139017b236eae24b503e359078

commit b85487654c37ae139017b236eae24b503e359078
Author: Stephen Martinis <martiniss@chromium.org>
Date: Tue Jul 10 20:37:14 2018

chromium_tests: Remove post_run

It turns out no test uses all 3 of pre_run, run, and post_run. At most
every test uses 2 of them. This CL removes post_run, which seemed to
be the least useful.

Some steps will shift order; this is because some tests used `run` (like
PythonTest) and some used `post_run` (like swarming tests). Both of these
were collapsed into just `run`, which can cause the order of tests to
shift slightly. It shouldn't affect anything significantly.

Bug:  858869 
Change-Id: I69d5029fb01c1a91df4f3a171bf84316e1410fbc
Reviewed-on: https://chromium-review.googlesource.com/1119501
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x_.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__failing_archive.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/test_utils/tests/run_tests.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/tests/steps/experimental_test.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_isolated_script_test.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_gtest.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x__dbg_.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/tests/steps/swarming_gtest_test.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_isolated_script_test.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32__m_nexus5x_.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_script.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/tests/steps/mock_test.expected/basic.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win10_.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_experimental.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/webrtc/steps.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64__m_nexus5x__dbg_.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_isolated_script.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/README.recipes.md
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_win64_debug__win8_.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/test_utils/api.py
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_gpu.json
[modify] https://crrev.com/b85487654c37ae139017b236eae24b503e359078/scripts/slave/recipe_modules/chromium_tests/tests/steps/mock_test.py

Comment 6 by martiniss@chromium.org, Jul 12

Status: Fixed (was: Assigned)
This is done.
►

Sign in to add a comment