New issue
Advanced search Search tips

Issue 858864 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 857573



Sign in to add a comment

Omnibox Test Failures with Material Refresh and MacViews

Project Member Reported by robliao@chromium.org, Jun 28 2018

Issue description

interactive_ui_tests
OmniboxViewTest.PreserveDisplayTextOnFocusSearch
OmniboxApiTest.ExtensionSuggestionsOnlyInKeywordMode
OmniboxViewTest.Paste
OmniboxViewTest.BackspaceInKeywordMode
OmniboxViewTest.UndoRedo

Are failing with

[99730:775:0628/161832.997724:FATAL:bridged_native_widget.mm(1058)] Check failed: window_visible_. 
0   interactive_ui_tests                0x000000010fa0a5ee base::debug::StackTrace::StackTrace(unsigned long) + 174
1   interactive_ui_tests                0x000000010fa0a64d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   interactive_ui_tests                0x000000010f6b4ffc base::debug::StackTrace::StackTrace() + 28
3   interactive_ui_tests                0x000000010f722dac logging::LogMessage::~LogMessage() + 460
4   interactive_ui_tests                0x000000010f71b185 logging::LogMessage::~LogMessage() + 21
5   interactive_ui_tests                0x000000010f5a88d0 views::BridgedNativeWidget::OnPaintLayer(ui::PaintContext const&) + 240
6   interactive_ui_tests                0x0000000113459d40 ui::Layer::PaintContentsToDisplayList(cc::ContentLayerClient::PaintingControlSetting) + 688
7   interactive_ui_tests                0x000000011345a1b6 non-virtual thunk to ui::Layer::PaintContentsToDisplayList(cc::ContentLayerClient::PaintingControlSetting) + 38
8   interactive_ui_tests                0x00000001113e211b cc::PictureLayer::Update() + 1163
9   interactive_ui_tests                0x00000001115b8822 cc::LayerTreeHost::PaintContent(std::__1::vector<scoped_refptr<cc::Layer>, std::__1::allocator<scoped_refptr<cc::Layer> > > const&, bool*, bool*) + 498
10  interactive_ui_tests                0x00000001115b7623 cc::LayerTreeHost::DoUpdateLayers(cc::Layer*) + 6131
11  interactive_ui_tests                0x00000001115b5b0e cc::LayerTreeHost::UpdateLayers() + 286
12  interactive_ui_tests                0x00000001116c7570 cc::SingleThreadProxy::DoPainting() + 32
13  interactive_ui_tests                0x00000001116c9189 cc::SingleThreadProxy::BeginMainFrame(viz::BeginFrameArgs const&) + 2377
14  interactive_ui_tests                0x000000011172306f void base::internal::FunctorTraits<void (cc::SingleThreadProxy::*)(viz::BeginFrameArgs const&), void>::Invoke<void (cc::SingleThreadProxy::*)(viz::BeginFrameArgs const&), base::WeakPtr<cc::SingleThreadProxy>, viz::BeginFrameArgs>(void (cc::SingleThreadProxy::*)(viz::BeginFrameArgs const&), base::WeakPtr<cc::SingleThreadProxy>&&, viz::BeginFrameArgs&&) + 143
15  interactive_ui_tests                0x0000000111722f75 void base::internal::InvokeHelper<true, void>::MakeItSo<void (cc::SingleThreadProxy::*)(viz::BeginFrameArgs const&), base::WeakPtr<cc::SingleThreadProxy>, viz::BeginFrameArgs>(void (cc::SingleThreadProxy::*&&)(viz::BeginFrameArgs const&), base::WeakPtr<cc::SingleThreadProxy>&&, viz::BeginFrameArgs&&) + 117
16  interactive_ui_tests                0x0000000111722eed void base::internal::Invoker<base::internal::BindState<void (cc::SingleThreadProxy::*)(viz::BeginFrameArgs const&), base::WeakPtr<cc::SingleThreadProxy>, viz::BeginFrameArgs>, void ()>::RunImpl<void (cc::SingleThreadProxy::*)(viz::BeginFrameArgs const&), std::__1::tuple<base::WeakPtr<cc::SingleThreadProxy>, viz::BeginFrameArgs>, 0ul, 1ul>(void (cc::SingleThreadProxy::*&&)(viz::BeginFrameArgs const&), std::__1::tuple<base::WeakPtr<cc::SingleThreadProxy>, viz::BeginFrameArgs>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 125
17  interactive_ui_tests                0x0000000111722e09 base::internal::Invoker<base::internal::BindState<void (cc::SingleThreadProxy::*)(viz::BeginFrameArgs const&), base::WeakPtr<cc::SingleThreadProxy>, viz::BeginFrameArgs>, void ()>::RunOnce(base::internal::BindStateBase*) + 57
18  interactive_ui_tests                0x00000001031a1c9c base::OnceCallback<void ()>::Run() && + 92
19  interactive_ui_tests                0x0000000111f37b41 ui::(anonymous namespace)::WrappedTask::Run() + 65
20  interactive_ui_tests                0x0000000111f388ad void base::internal::FunctorTraits<void (ui::(anonymous namespace)::WrappedTask::*)(), void>::Invoke<void (ui::(anonymous namespace)::WrappedTask::*)(), ui::(anonymous namespace)::WrappedTask*>(void (ui::(anonymous namespace)::WrappedTask::*)(), ui::(anonymous namespace)::WrappedTask*&&) + 125
21  interactive_ui_tests                0x0000000111f387f4 void base::internal::InvokeHelper<false, void>::MakeItSo<void (ui::(anonymous namespace)::WrappedTask::* const&)(), ui::(anonymous namespace)::WrappedTask*>(void (ui::(anonymous namespace)::WrappedTask::* const&&&)(), ui::(anonymous namespace)::WrappedTask*&&) + 68
22  interactive_ui_tests                0x0000000111f38783 void base::internal::Invoker<base::internal::BindState<void (ui::(anonymous namespace)::WrappedTask::*)(), base::internal::OwnedWrapper<ui::(anonymous namespace)::WrappedTask> >, void ()>::RunImpl<void (ui::(anonymous namespace)::WrappedTask::* const&)(), std::__1::tuple<base::internal::OwnedWrapper<ui::(anonymous namespace)::WrappedTask> > const&, 0ul>(void (ui::(anonymous namespace)::WrappedTask::* const&&&)(), std::__1::tuple<base::internal::OwnedWrapper<ui::(anonymous namespace)::WrappedTask> > const&&&, std::__1::integer_sequence<unsigned long, 0ul>) + 99
23  interactive_ui_tests                0x0000000111f386bc base::internal::Invoker<base::internal::BindState<void (ui::(anonymous namespace)::WrappedTask::*)(), base::internal::OwnedWrapper<ui::(anonymous namespace)::WrappedTask> >, void ()>::Run(base::internal::BindStateBase*) + 44
24  interactive_ui_tests                0x00000001031a1c9c base::OnceCallback<void ()>::Run() && + 92
25  interactive_ui_tests                0x000000010f6b63b9 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1033
26  interactive_ui_tests                0x000000010f74f39a base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) + 234
27  interactive_ui_tests                0x000000010f757188 base::MessageLoop::RunTask(base::PendingTask*) + 872
28  interactive_ui_tests                0x000000010f757449 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 89
29  interactive_ui_tests                0x000000010f75773a base::MessageLoop::DoWork() + 570
30  interactive_ui_tests                0x000000010fa6d552 base::MessagePumpCFRunLoopBase::RunWork() + 98
31  interactive_ui_tests                0x000000010fa6d4dc ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28
32  interactive_ui_tests                0x000000010fa7a78a base::mac::CallWithEHFrame(void () block_pointer) + 10
33  interactive_ui_tests                0x000000010fa6c3b5 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 101
34  CoreFoundation                      0x00007fff51d3aa61 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
35  CoreFoundation                      0x00007fff51df447c __CFRunLoopDoSource0 + 108
36  CoreFoundation                      0x00007fff51d1d4c0 __CFRunLoopDoSources0 + 208
37  CoreFoundation                      0x00007fff51d1c93d __CFRunLoopRun + 1293
38  CoreFoundation                      0x00007fff51d1c1a3 CFRunLoopRunSpecific + 483
39  HIToolbox                           0x00007fff51002d96 RunCurrentEventLoopInMode + 286
40  HIToolbox                           0x00007fff51002b06 ReceiveNextEventCommon + 613
41  HIToolbox                           0x00007fff51002884 _BlockUntilNextEventMatchingListInModeWithFilter + 64
42  AppKit                              0x00007fff4f2b4a73 _DPSNextEvent + 2085
43  AppKit                              0x00007fff4fa4ae34 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044
44  interactive_ui_tests                0x000000010d243c6a __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 106
45  interactive_ui_tests                0x000000010fa7a78a base::mac::CallWithEHFrame(void () block_pointer) + 10
46  interactive_ui_tests                0x000000010d243b08 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 248
47  AppKit                              0x00007fff4f2a9885 -[NSApplication run] + 764
48  interactive_ui_tests                0x000000010fa6ebbc base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 348
49  interactive_ui_tests                0x000000010fa6ba45 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 101
50  interactive_ui_tests                0x000000010f75696c base::MessageLoop::Run(bool) + 556
51  interactive_ui_tests                0x000000010f81d0ee base::RunLoop::Run() + 606
52  interactive_ui_tests                0x000000010bd0572c InProcessBrowserTest::RunUntilBrowserProcessQuits() + 60
53  interactive_ui_tests                0x000000010bd064d0 InProcessBrowserTest::QuitBrowsers() + 352
54  interactive_ui_tests                0x000000010bd062bb InProcessBrowserTest::PostRunTestOnMainThread() + 75
55  interactive_ui_tests                0x000000010db1e42d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 2893
56  interactive_ui_tests                0x000000010db4ffad void base::internal::FunctorTraits<void (content::BrowserTestBase::*)(), void>::Invoke<void (content::BrowserTestBase::*)(), content::BrowserTestBase*>(void (content::BrowserTestBase::*)(), content::BrowserTestBase*&&) + 125
57  interactive_ui_tests                0x000000010db4fef4 void base::internal::InvokeHelper<false, void>::MakeItSo<void (content::BrowserTestBase::* const&)(), content::BrowserTestBase*>(void (content::BrowserTestBase::* const&&&)(), content::BrowserTestBase*&&) + 68
58  interactive_ui_tests                0x000000010db4fe83 void base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase> >, void ()>::RunImpl<void (content::BrowserTestBase::* const&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase> > const&, 0ul>(void (content::BrowserTestBase::* const&&&)(), std::__1::tuple<base::internal::UnretainedWrapper<content::BrowserTestBase> > const&&&, std::__1::integer_sequence<unsigned long, 0ul>) + 99
59  interactive_ui_tests                0x000000010db4fdbc base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(), base::internal::UnretainedWrapper<content::BrowserTestBase> >, void ()>::Run(base::internal::BindStateBase*) + 44
60  interactive_ui_tests                0x0000000102170c3d base::RepeatingCallback<void ()>::Run() const & + 61
61  interactive_ui_tests                0x000000010bebf25f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 8591
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6dcc165e0701e3dd1799cb53fb785360e1f2564

commit a6dcc165e0701e3dd1799cb53fb785360e1f2564
Author: Robert Liao <robliao@chromium.org>
Date: Tue Jul 03 14:30:39 2018

Remove window_visible_ DCHECK on BridgedNativeWidget

Hiding the Layer can also trigger a paint request.
This causes the following omnibox interactive_ui_tests to fail with material refresh:
OmniboxViewTest.PreserveDisplayTextOnFocusSearch
OmniboxApiTest.ExtensionSuggestionsOnlyInKeywordMode
OmniboxViewTest.Paste
OmniboxViewTest.BackspaceInKeywordMode
OmniboxViewTest.UndoRedo

* thread #1, name = 'CrBrowserMain', queue = 'com.apple.main-thread'
  * frame #0: libcc.dylib`cc::SchedulerStateMachine::SetNeedsBeginMainFrame(this) at scheduler_state_machine.cc:1279
    frame #1: libcc.dylib`cc::Scheduler::SetNeedsBeginMainFrame(this) at scheduler.cc:116
    frame #2: libcc.dylib`cc::SingleThreadProxy::SetNeedsCommit(this) at single_thread_proxy.cc:244
    frame #3: libcc.dylib`cc::LayerTreeHost::SetNeedsCommit(this) at layer_tree_host.cc:536
    frame #4: libcc.dylib`cc::Layer::SetNeedsCommit(this) at layer.cc:166
    frame #5: libcc.dylib`cc::Layer::SetHideLayerAndSubtree(this, hide=true) at layer.cc:1085
    frame #6: libcompositor.dylib`ui::Layer::SetVisibilityFromAnimation(this, visible=false, reason=NOT_FROM_ANIMATION) at layer.cc:1164
    frame #7: libcompositor.dylib`ui::LayerAnimator::SetVisibility(this, value=false) at layer_animator.cc:115
    frame #8: libcompositor.dylib`ui::Layer::SetVisible(this, visible=false) at layer.cc:537
    frame #9: libviews.dylib`views::BridgedNativeWidget::OnVisibilityChanged(this) at bridged_native_widget.mm:796
(lldb) frame select 9
(lldb) print this->window_visible_
(bool) $0 = false

BUG= 858864 

Change-Id: I07014b36e289ecc942e25a2e789517ef76fd5a1b
Reviewed-on: https://chromium-review.googlesource.com/1121324
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572204}
[modify] https://crrev.com/a6dcc165e0701e3dd1799cb53fb785360e1f2564/ui/views/cocoa/bridged_native_widget.mm

Status: Fixed (was: Started)

Sign in to add a comment