Skylab: Add job keyval support
xixuan, can you add all of the keyvals you need as tags/dimensions on the task? Then we can read them from the swarming worker and add them to the keyval file.
Decided to pass keyvals as swarming task tags
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/a7e2cfdd8bbfea2a80b42695a8d46517add65d89 commit a7e2cfdd8bbfea2a80b42695a8d46517add65d89 Author: Allen Li <ayatane@google.com> Date: Mon Jul 02 23:00:36 2018 autotest: Add WriteKeyvals function BUG= chromium:858850 TEST=None Change-Id: I6e1ed250cdcb09e268db7be7ff99e63c7ec4a13a Reviewed-on: https://chromium-review.googlesource.com/1121244 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/a7e2cfdd8bbfea2a80b42695a8d46517add65d89/src/lucifer/autotest/autotest.go [add] https://crrev.com/a7e2cfdd8bbfea2a80b42695a8d46517add65d89/src/lucifer/autotest/autotest_test.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/ae3b932aed5775d83a6ba5a5959a766d7ed3355e commit ae3b932aed5775d83a6ba5a5959a766d7ed3355e Author: Allen Li <ayatane@google.com> Date: Mon Jul 02 23:00:36 2018 flagx: Clean up tests Clean up done while adding JSONMap for keyval support. Moved into separate commit for ease of review. BUG= chromium:858850 TEST=None Change-Id: I11a2d6c5d5e41329f87bec9b9784fb00f0086070 Reviewed-on: https://chromium-review.googlesource.com/1121245 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/ae3b932aed5775d83a6ba5a5959a766d7ed3355e/src/lucifer/flagx/flagx_test.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/e6bc61396dbf99446f5906b12839b3388561e147 commit e6bc61396dbf99446f5906b12839b3388561e147 Author: Allen Li <ayatane@google.com> Date: Tue Jul 03 02:40:35 2018 flagx: Add JSONMap Add JSONMap for keyval support. BUG= chromium:858850 TEST=None Change-Id: Ie4c71605d3cbbec149f78297473e5a7b4b2f705c Reviewed-on: https://chromium-review.googlesource.com/1121246 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/e6bc61396dbf99446f5906b12839b3388561e147/src/lucifer/flagx/flagx_test.go [modify] https://crrev.com/e6bc61396dbf99446f5906b12839b3388561e147/src/lucifer/flagx/flagx.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/06ecf3af39471c4b92ec13868a0ffe294579f257 commit 06ecf3af39471c4b92ec13868a0ffe294579f257 Author: Allen Li <ayatane@google.com> Date: Tue Jul 03 18:59:10 2018 lucifer_run_job: Add keyval support Swarming will also need support; separate commit for that since this is pretty big. BUG= chromium:858850 TEST=None Change-Id: I7ec214c1e686f66073e7bd721c69852e514b146a Reviewed-on: https://chromium-review.googlesource.com/1121237 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/06ecf3af39471c4b92ec13868a0ffe294579f257/src/lucifer/oldcmd/lucifer_run_job/main.go [modify] https://crrev.com/06ecf3af39471c4b92ec13868a0ffe294579f257/src/lucifer/oldcmd/lucifer_run_job/flags.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/ec3f16bc2e66918290f2236a95337ae712157ac2 commit ec3f16bc2e66918290f2236a95337ae712157ac2 Author: Allen Li <ayatane@google.com> Date: Tue Jul 03 18:59:11 2018 skylab_swarming_worker: Add keyval support BUG= chromium:858850 TEST=None Change-Id: I693d9ef4c74ed0f4cb4cfb0490597b9c2df7e24f Reviewed-on: https://chromium-review.googlesource.com/1123653 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/ec3f16bc2e66918290f2236a95337ae712157ac2/src/lucifer/client/lucifer/lucifer.go [modify] https://crrev.com/ec3f16bc2e66918290f2236a95337ae712157ac2/src/lucifer/cmd/skylab_swarming_worker/main.go
Seems like this is needed in the current phase (mark skylab-based paladin important)
I think xixuan verified this?
Comment 1 by ayatane@chromium.org
, Jun 29 2018