New issue
Advanced search Search tips

Issue 858848 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 696822



Sign in to add a comment

Declarative Net Request: Ensure that we don't pack the indexed ruleset.

Project Member Reported by karandeepb@chromium.org, Jun 28 2018

Issue description

We should ensure that we don't end up packing the _metadata folder (which contains the indexed ruleset file) while packing an extension. This could lead to unnecessarily inflating the crx package size.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6a6c3c302a6ebde30dafd7fb280ae31e8e7065a

commit c6a6c3c302a6ebde30dafd7fb280ae31e8e7065a
Author: Karan Bhatia <karandeepb@chromium.org>
Date: Wed Jul 11 04:35:03 2018

Extensions: Exclude _metadata folder from being packed.

This CL ensures that the reserved _metadata folder is not included in the packed
extension package. This should be safe as:
  - Webstore already disallows packages with a _metadata folder.
  - We already disallow loading unpacked extensions with non-reserved files in
    the _metadata folder (r502478).

This should help ensure that unpacked extensions using the Declarative Net
Request API don't have the indexed ruleset in the crx package.

BUG= 858848 

Change-Id: I6d175eae16457531a54818c2d801852dc41df8bc
Reviewed-on: https://chromium-review.googlesource.com/1132544
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574071}
[modify] https://crrev.com/c6a6c3c302a6ebde30dafd7fb280ae31e8e7065a/extensions/browser/extension_creator.cc
[modify] https://crrev.com/c6a6c3c302a6ebde30dafd7fb280ae31e8e7065a/extensions/browser/extension_creator_filter.cc
[modify] https://crrev.com/c6a6c3c302a6ebde30dafd7fb280ae31e8e7065a/extensions/browser/extension_creator_filter.h
[modify] https://crrev.com/c6a6c3c302a6ebde30dafd7fb280ae31e8e7065a/extensions/browser/extension_creator_filter_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment