Issue metadata
Sign in to add a comment
|
Video playback on latest Chrome browser on Pixel 2 is non-responsive and requires multiple taps |
||||||||||||||||||||||
Issue descriptionChrome Version : 67.0.3396.87 (32 bit on Pixel 2) URLs (if applicable) : https://posts.google.com/bulletin/share/uAjrT6kF/1EvJfj/ https://nonmanaged-83a7144b-2992ced6122fb98d.demos.corp.google.com/bulletin/share/uAjrT6kF/1EvJfj/?_hostType=//java/com/google/news/recorder/hosttype Other browsers tested: Add OK or FAIL, along with the version, after other browsers where you have tested this issue: Safari: OK Firefox: OK Edge: not tested Chrome on IOS: OK Chrome on Moto X (version 48.0.2564.95): OK What steps will reproduce the problem? (1) Just try to play any video embedded in the URLs that are included in the bug. (2) (3) What is the expected result? We should be able to play the videos with not a lot of effort and not a lot of tapping. What happens instead? Videos don't play unless there are multiple taps (if you're lucky). Please provide any additional information below. Attach a screenshot if possible.
,
Jun 29 2018
,
Jul 3
Tested the issue in Android and able to reproduce the issue. Steps Followed: 1. Launch Chrome. 2. Navigate to https://posts.google.com/bulletin/share/uAjrT6kF/1EvJfj/ 3. Tap on embedded video and Observed that video playback is unresponsive. 4. Also observed that it requires multiple taps Chrome versions tested: 68.0.3440.40(Beta), 69.0.3479.2(Latest canary) OS: Android 8.1.0 Android Devices: Pixel 2 Unable to provide per-revision bisect as builds are not invoking for below mentioned range.Hence, providing manual bisect results, Good Build - 68.0.3436.0 560158 Bad Build - 68.0.3437.0 560453 Marking this as Untriaged for further inputs on this. Note:Adding Rb-stable ,please undo if not the case. Please navigate to below link for log's -- go/chrome-androidlogs/858846 Thanks!
,
Jul 3
Please take a look at this blocker as soon as possible.
,
Jul 3
I was able to reproduce the bug in M67 so it doesn't look like a M68 regression. Assigning to steimel@ as it's likely a controls issue.
,
Jul 10
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88dd2a898975364085c5566a30b82a62efd79984 commit 88dd2a898975364085c5566a30b82a62efd79984 Author: Tommy Steimel <steimel@chromium.org> Date: Tue Jul 10 20:43:41 2018 Media Controls: Keep more overlay play button events in node This CL undoes some of crrev.com/c/1067514, which kept fewer events in node for the overlay play button to fix a menu issue. Instead of allowing all non-play/pause-causing events through, we are only going to allow non-play/pause-causing "click" events through. This keeps the original issue fixed while also fixing a new issue where outer divs could preventDefault on certain touch events to prevent the overlay play button from receiving a "click" event. Bug: 858846 Change-Id: I1c10e188529edd1219cee42ded5865442becb8f8 Reviewed-on: https://chromium-review.googlesource.com/1130826 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#573896} [add] https://crrev.com/88dd2a898975364085c5566a30b82a62efd79984/third_party/WebKit/LayoutTests/media/controls/tap-on-overlay-play-button-cant-be-preempted.html [modify] https://crrev.com/88dd2a898975364085c5566a30b82a62efd79984/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/88dd2a898975364085c5566a30b82a62efd79984/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
,
Jul 11
I have fixed the given problem, which is the inability to press on the overlay play button. However, there is a remaining issue where once the controls have hidden, you can't tap to bring them back. This has a similar cause but is mostly an issue on Bulletin's end (I've started a thread with them). Additionally, that issue has been around since before the new controls, so it is not a regression. Merge requesting the CL in comment 7. I've tested in Canary and it's working
,
Jul 11
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc8cb1847945e7cf61c32ae25f395aedeee76624 commit dc8cb1847945e7cf61c32ae25f395aedeee76624 Author: Tommy Steimel <steimel@chromium.org> Date: Fri Jul 13 17:11:12 2018 Media Controls: Keep more overlay play button events in node This CL undoes some of crrev.com/c/1067514, which kept fewer events in node for the overlay play button to fix a menu issue. Instead of allowing all non-play/pause-causing events through, we are only going to allow non-play/pause-causing "click" events through. This keeps the original issue fixed while also fixing a new issue where outer divs could preventDefault on certain touch events to prevent the overlay play button from receiving a "click" event. Bug: 858846 Change-Id: I1c10e188529edd1219cee42ded5865442becb8f8 Reviewed-on: https://chromium-review.googlesource.com/1130826 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#573896}(cherry picked from commit 88dd2a898975364085c5566a30b82a62efd79984) Reviewed-on: https://chromium-review.googlesource.com/1136751 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#665} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [add] https://crrev.com/dc8cb1847945e7cf61c32ae25f395aedeee76624/third_party/WebKit/LayoutTests/media/controls/tap-on-overlay-play-button-cant-be-preempted.html [modify] https://crrev.com/dc8cb1847945e7cf61c32ae25f395aedeee76624/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/dc8cb1847945e7cf61c32ae25f395aedeee76624/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
,
Jul 19
This issue is fixed in current M68 build 68.0.3440.70. Embedded videos play upon one tap.
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecf86135a4b87d7ce63096f656b04ef586ae334a commit ecf86135a4b87d7ce63096f656b04ef586ae334a Author: Tommy Steimel <steimel@chromium.org> Date: Fri Jul 20 17:18:47 2018 Revert "Media Controls: Keep more overlay play button events in node" This reverts commit dc8cb1847945e7cf61c32ae25f395aedeee76624. Reason for revert: Causing new issues on YT Creator: crbug.com/864739 Original change's description: > Media Controls: Keep more overlay play button events in node > > This CL undoes some of crrev.com/c/1067514, which kept fewer events in > node for the overlay play button to fix a menu issue. Instead of > allowing all non-play/pause-causing events through, we are only going > to allow non-play/pause-causing "click" events through. This keeps the > original issue fixed while also fixing a new issue where outer divs > could preventDefault on certain touch events to prevent the overlay > play button from receiving a "click" event. > > Bug: 858846 > Change-Id: I1c10e188529edd1219cee42ded5865442becb8f8 > Reviewed-on: https://chromium-review.googlesource.com/1130826 > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#573896}(cherry picked from commit 88dd2a898975364085c5566a30b82a62efd79984) > Reviewed-on: https://chromium-review.googlesource.com/1136751 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/branch-heads/3440@{#665} > Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} TBR=steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 858846 Change-Id: I9d02798fcc5c04c1b47d7beacd4627e261881431 Reviewed-on: https://chromium-review.googlesource.com/1145442 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#726} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [delete] https://crrev.com/7d210b09a3e0418803ed72eb781fdf4b8147a9f5/third_party/WebKit/LayoutTests/media/controls/tap-on-overlay-play-button-cant-be-preempted.html [modify] https://crrev.com/ecf86135a4b87d7ce63096f656b04ef586ae334a/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/ecf86135a4b87d7ce63096f656b04ef586ae334a/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
,
Jul 20
This fix ended up breaking some other things so we're pulling this out of M68. There's a fix for the break in M69 but it was far too late to merge that into M68 (which goes stable on Tuesday). |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vamshi.kommuri@chromium.org
, Jun 29 2018Components: Blink>Media>Video
Labels: Triaged-ET Needs-Triage-M67 OS-Android