New issue
Advanced search Search tips

Issue 858822 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Allow users to trigger setup flow by searching for "Linux"

Project Member Reported by tbuck...@chromium.org, Jun 28 2018

Issue description

In addition to showing the Terminal if a user searches for it, we should also have a "Set up Linux" action that users can search for from the Launcher. It's icon should be the penguin, and it should only be available if Crostini has not yet been set up. Selecting it should launch the setup flow.
 
Status: Assigned (was: Available)
Labels: M-71
Cc: tbuck...@chromium.org
Going to take a look. Quick question -- what do we want to do with localization? Currently we only search for the localized "Terminal", which could be e.g. "Terminale", "Terminál", "ターミナル", and so on. Should we do the same for the "Linux" keyword, or maybe add the English alternatives for both queries?
should do both.  "Linux" is a proper name and less likely to have a translation other than perhaps a transliteration (like what Japanese often does -- ターミナル is simply "Taa-mi-na-ru").
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45d0ecd879d723c372675470d03aac771118ac2b

commit 45d0ecd879d723c372675470d03aac771118ac2b
Author: Timothy Loh <timloh@chromium.org>
Date: Tue Nov 06 03:52:59 2018

Improve searching for the Crostini Terminal

This CL makes a few improvements in searching for the Crostini Terminal:
- Allow partial matches ( bug 840699 ). Instead of requiring the entire
word 'terminal', allowa match from just 'ter' (but still require a few
characters to avoid over-triggering).
- Add additional keywords 'linux', 'crostini' ( bug 858822 ).
- Add unlocalized (English) keywords. Users may still search for these
as localizations of Linux/Crostini tend to be tranliterations.

Bug:  840699 ,  858822 
Change-Id: Iabff74d9d8a61c2c2abcc50f9683b381c5dce126
Reviewed-on: https://chromium-review.googlesource.com/c/1280092
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605589}
[modify] https://crrev.com/45d0ecd879d723c372675470d03aac771118ac2b/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/45d0ecd879d723c372675470d03aac771118ac2b/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/45d0ecd879d723c372675470d03aac771118ac2b/chrome/browser/ui/app_list/search/tests/app_search_provider_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment