See: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/7783 Given the other failures, apparently more than one bad CL effecting this bot though.
FindIt tells me with 100% confidence that this is the culprit CL: (1) https://crrev.com/c/1100237 But to revert it I also have to revert a followup of it: (2) https://crrev.com/c/1105568 So I'm reverting (2) and then (1).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76 commit 4c2ee1dc602ae4e8e55af5cf0de11bec04188f76 Author: Carlos Knippschild <carlosk@chromium.org> Date: Thu Jun 28 21:57:24 2018 Revert "Implement content of progress and error dialogs according to mocks." This reverts commit 1f7e073e5b0bf2f6846f3c35a87ac813631983a5. Reason for revert: Revert 1 of 2 - FindIt flagged https://crrev.com/c/1100237 with 100% confidence of breaking "Linux ChromiumOS MSan Tests" bot (DemoSetupTest.ProceedThroughSetupFlowSetupError); revering this CL is needed to be able to revert that one. Original change's description: > Implement content of progress and error dialogs according to mocks. > > Bug: 827376 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I16781ef2ad241f28da0eef3126d9b6a66840f828 > Reviewed-on: https://chromium-review.googlesource.com/1105568 > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571202} TBR=mukai@chromium.org,alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org Change-Id: I86eba9fb27bc78941b9caab8c69bf983f17b19f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827376 , 858817 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1119267 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#571283} [modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/browser/resources/chromeos/login/demo_setup.css [modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/browser/resources/chromeos/login/demo_setup.html [modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/browser/resources/chromeos/login/demo_setup.js [delete] https://crrev.com/89b548a0bae43ef770c8e82a0e396d08c0cc53d4/chrome/browser/resources/chromeos/login/images/alert-illustration_1x.svg [delete] https://crrev.com/89b548a0bae43ef770c8e82a0e396d08c0cc53d4/chrome/browser/resources/chromeos/login/images/alert-illustration_2x.svg [modify] https://crrev.com/4c2ee1dc602ae4e8e55af5cf0de11bec04188f76/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19f25b9378c776fcb305f4204733045c565a800f commit 19f25b9378c776fcb305f4204733045c565a800f Author: Carlos Knippschild <carlosk@chromium.org> Date: Thu Jun 28 21:59:45 2018 Revert "Add skeleton of Demo Mode setup UI." This reverts commit c618b6e7c717459d8f853c61904e4a53314ed17c. Reason for revert: Revert 2 of 2 - FindIt flagged this CL with 100% confidence of breaking "Linux ChromiumOS MSan Tests" bot (DemoSetupTest.ProceedThroughSetupFlowSetupError); had to revert https://chromium-review.googlesource.com/1105568 first to be able to revert this one. Original change's description: > Add skeleton of Demo Mode setup UI. > > Mocks: > https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCGxzIhEyEZFkDOfw1G1Tu4Z > > Bug: 827376 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: I1206687fff441ec6be5a3bb9e6dddba7469f292b > Reviewed-on: https://chromium-review.googlesource.com/1100237 > Commit-Queue: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571137} TBR=mukai@chromium.org,alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org Change-Id: I49ab0b951ced812d56f5fc14e953da854f085b50 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827376 , 858817 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1119305 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#571285} [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc [delete] https://crrev.com/b99858190e95d9a3149a71f6db6d0685f073d0fb/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.h [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/demo_setup_browsertest.cc [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/screens/demo_setup_screen.cc [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/screens/demo_setup_screen_view.h [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/chromeos/login/screens/mock_demo_setup_screen.h [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/resources/chromeos/login/demo_setup.css [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/resources/chromeos/login/demo_setup.html [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/resources/chromeos/login/demo_setup.js [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.js [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.h [modify] https://crrev.com/19f25b9378c776fcb305f4204733045c565a800f/chrome/test/BUILD.gn
For completeness sake, this is the link to the respective FindIt analysis: https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7783 (The SoM page provides broken FindIt links hence my only adding it now; filed issue 857600 )
FindIt was correct and the revert fixed this test breakage in build #7786
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2 commit e29f5b811c91c64c97a0e71c8d3436d02a37e9f2 Author: Aga Wronska <agawronska@chromium.org> Date: Fri Jun 29 22:07:24 2018 Reland "Implement content of progress and error dialogs according to mocks." This reverts commit 4c2ee1dc602ae4e8e55af5cf0de11bec04188f76. Original change's description: > Revert "Implement content of progress and error dialogs according to mocks." > > This reverts commit 1f7e073e5b0bf2f6846f3c35a87ac813631983a5. > > Reason for revert: Revert 1 of 2 - FindIt flagged https://crrev.com/c/1100237 with 100% confidence of breaking "Linux ChromiumOS MSan Tests" bot (DemoSetupTest.ProceedThroughSetupFlowSetupError); revering this CL is needed to be able to revert that one. > > Original change's description: > > Implement content of progress and error dialogs according to mocks. > > > > Bug: 827376 > > Cq-Include-Trybots: luci.chromium.try:closure_compilation > > Change-Id: I16781ef2ad241f28da0eef3126d9b6a66840f828 > > Reviewed-on: https://chromium-review.googlesource.com/1105568 > > Commit-Queue: Aga Wronska <agawronska@chromium.org> > > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > > Reviewed-by: Jun Mukai <mukai@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#571202} > > TBR=mukai@chromium.org,alemate@chromium.org,michaelpg@chromium.org,agawronska@chromium.org > > Change-Id: I86eba9fb27bc78941b9caab8c69bf983f17b19f0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 827376 , 858817 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Reviewed-on: https://chromium-review.googlesource.com/1119267 > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Commit-Queue: Carlos Knippschild <carlosk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571283} Change-Id: I80071a9c745712e4e9f5b58c730edfb1f3d716e7 Bug: 827376 , 858817 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1119269 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#571664} [modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/demo_setup.css [modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/demo_setup.html [modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/demo_setup.js [add] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/images/alert-illustration_1x.svg [add] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/resources/chromeos/login/images/alert-illustration_2x.svg [modify] https://crrev.com/e29f5b811c91c64c97a0e71c8d3436d02a37e9f2/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc
Comment 1 by carlosk@chromium.org
, Jun 28 2018