Go to https://cs.chromium.org/chromium/src/third_party/custom_tabs_client/ It some files, but not the src/ directory with all the actual code inside of it. Additionally, those src files are not indexed by codesearch.
Go to https://cs.chromium.org/chromium/src/third_party/custom_tabs_client/ It has some files, but not the src/ directory with all the actual code inside of it. Additionally, those src files are not indexed by codesearch.
Looks like we're not creating a submodule for this repo any more (and probably others too). I think this is related to the recent changes to deps2submodules - Alan, do you know what's going on here?
Issue 859828 has been merged into this issue.
Since Alan's on vacation this week: Edward, do you have any ideas about this?
I looked into this a little myself, and I think I have a fix: https://chromium-review.googlesource.com/c/infra/infra/+/1125557
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/c404890171a4525698834404cc2fce2b0d95ab2b commit c404890171a4525698834404cc2fce2b0d95ab2b Author: Joey Scarr <jsca@google.com> Date: Thu Jul 05 03:44:46 2018 Target every OS in the sync_submodules checkout. This allows us to meet most of the conditionals specified in the chromium DEPS file, which should allow us to include as much code as possible in CS. This should fix a regression caused by crrev.com/c/1104963. Before that CL, the old custom DEPS parsing logic would ignore all conditionals (except for checkout_google_internal), effectively treating them as true. Once we started using the canonical logic, we stopped including all conditional deps. TBR=agable@chromium.org Bug: 857606 Change-Id: Ic71a068fa0e07c3c4f545973e701b4a67cee3b7c Reviewed-on: https://chromium-review.googlesource.com/1125557 Reviewed-by: Joey Scarr <jsca@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> [modify] https://crrev.com/c404890171a4525698834404cc2fce2b0d95ab2b/recipes/recipes/sync_submodules.expected/basic_with_prefix.json [modify] https://crrev.com/c404890171a4525698834404cc2fce2b0d95ab2b/recipes/recipe_modules/sync_submodules/api.py [modify] https://crrev.com/c404890171a4525698834404cc2fce2b0d95ab2b/recipes/recipes/sync_submodules.expected/basic_with_diff.json [modify] https://crrev.com/c404890171a4525698834404cc2fce2b0d95ab2b/recipes/recipes/sync_submodules.expected/basic_with_diff_failure.json [modify] https://crrev.com/c404890171a4525698834404cc2fce2b0d95ab2b/recipes/recipes/sync_submodules.expected/basic_experimental.json [modify] https://crrev.com/c404890171a4525698834404cc2fce2b0d95ab2b/recipes/recipes/sync_submodules.expected/with_one_extra_submodule.json [modify] https://crrev.com/c404890171a4525698834404cc2fce2b0d95ab2b/recipes/recipes/sync_submodules.expected/basic.json [modify] https://crrev.com/c404890171a4525698834404cc2fce2b0d95ab2b/recipes/recipes/sync_submodules.expected/with_two_extra_submodules.json [modify] https://crrev.com/c404890171a4525698834404cc2fce2b0d95ab2b/recipes/recipes/sync_submodules.expected/basic_with_prefix_disabled.json
Thanks for this, I can search third_party/custom_tabs_client again!
Comment 1 by orodley@chromium.org
, Jul 2Owner: flyboy@chromium.org
Status: Assigned (was: Untriaged)