New issue
Advanced search Search tips

Issue 857605 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

ADHD fails to build with USE="-cras-apm"

Project Member Reported by perley@google.com, Jun 28 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(1) USE="-cras-apm" emerge-${BOARD} adhd

What is the expected result? success

What happens instead? build fails with:


x86_64-cros-linux-gnu-clang++ -DPACKAGE_NAME=\"cras\" -DPACKAGE_TARNAME=\"cras\" -DPACKAGE_VERSION=\"0.1\" -DPACKAGE_STRING=\"cras\ 0.1\" -DPACKAGE_BUGREPORT=\"dgreid@chromium.org\" -DPACKAGE_URL=\"http://www.chromium.org/\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_LIBASOUND=1 -DALSA_PLUGIN_DIR=\"/usr/lib64/alsa-lib\" -DCRAS_CONFIG_FILE_DIR=\"/etc/cras\" -DCRAS_SOCKET_FILE_DIR=\"/run/cras\" -DHAVE_SSE42=1 -DHAVE_AVX=1 -DHAVE_AVX2=1 -DHAVE_FMA=1 -I.  -O2 -Wall -Werror -Wno-error=cpp -I../src/common -I../src/server -DVCSID='"0.0.1-r1528-65207dc91ec9f81f6e975bb559270c9ccfe77031"'  -O2 -pipe -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables   -fno-asynchronous-unwind-tables  -c -o tests/fmt_conv_unittest-fmt_conv_unittest.o `test -f 'tests/fmt_conv_unittest.cc' || echo './'`tests/fmt_conv_unittest.cc
tests/audio_thread_unittest.cc:1111:10: error: functions that differ only in their return type cannot be overloaded
uint64_t cras_apm_list_get_effects(struct cras_apm_list *list)
~~~~~~~~ ^
../src/server/cras_apm_list.h:143:28: note: previous definition is here
static inline unsigned int cras_apm_list_get_effects(struct cras_apm_list *list)
              ~~~~~~~~~~~~ ^
tests/audio_thread_unittest.cc:1120:6: error: redefinition of 'cras_apm_list_set_aec_dump'
void cras_apm_list_set_aec_dump(struct cras_apm_list *list,
     ^
../src/server/cras_apm_list.h:174:20: note: previous definition is here
static inline void cras_apm_list_set_aec_dump(struct cras_apm_list *list,
                   ^
2 errors generated.
make[2]: *** [Makefile:6935: tests/audio_thread_unittest-audio_thread_unittest.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/build/fizz-accelerator/tmp/portage/media-sound/adhd-0.0.1-r1528/work/adhd-0.0.1/cras/src'
make[1]: *** [Makefile:8364: check-am] Error 2
make[1]: Leaving directory '/build/fizz-accelerator/tmp/portage/media-sound/adhd-0.0.1-r1528/work/adhd-0.0.1/cras/src'
make: *** [Makefile:457: check-recursive] Error 1


Marking P2 as we can fix it in our board overlay with a package use, but it seems silly to have a use flag that doesn't work.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 29 2018

Comment 2 by hychao@chromium.org, Jun 29 2018

Owner: hychao@chromium.org
Status: Started (was: Untriaged)
sorry for the failure. I'm working on the fix now.

Comment 3 by perley@google.com, Jun 29 2018

No problem.  Doesn't really affect us other than the failed builds and CQ runs.  We don't do anything audio related on our platform, so just setting the use flag for the package unblocked us.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/9955a9076ff115eff58518663d8bce7b3bbffd13

commit 9955a9076ff115eff58518663d8bce7b3bbffd13
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Sun Jul 01 00:21:39 2018

CRAS: fix build for boards without webrtc-apm package

BUG=chromium:857605
TEST=USE="-cras-apm" emerge-soraka adhd

Change-Id: I2ae476947d311aa1bb57748639fd6436aa9f4d19
Reviewed-on: https://chromium-review.googlesource.com/1119945
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/9955a9076ff115eff58518663d8bce7b3bbffd13/cras/src/server/cras_apm_list.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 3

Labels: merge-merged-release-R66-10452.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/project-accelerator-private/+/dab2dfd591f142b36748386e8c06533de994857f

commit dab2dfd591f142b36748386e8c06533de994857f
Author: Pat Erley <perley@google.com>
Date: Tue Jul 03 18:16:44 2018

Sign in to add a comment