Make single Lucifer binary
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/046a68949c4ed5ed0d395ada86d035148a47e153 commit 046a68949c4ed5ed0d395ada86d035148a47e153 Author: Allen Li <ayatane@google.com> Date: Sat Jun 30 02:00:34 2018 lucifer: Make single entry point Make a single entry point for Lucifer, and make the separate binaries into subcommands. Rationale: * Go binaries are statically compiled. Thus, each entry point means carrying an extra copy of the Go runtime and any included libraries. The space needed for new libraries (e.g., for LogDog) is multiplied. Space is limited on Moblab. * Lucifer binaries share a lot of code; moving them into a single command makes reuse easier. * Adding new binaries is more work than adding subcommands, so we can amortize the cost of doing this change by not having to make new binaries for Lucifer again. Changes: * Move existing entry points into packages under oldcmd and make their Main exported. * Add a bare bones lucifer command that imports and calls into the old Main functions. Non-changes: * Old entry points are kept for the duration of the switchover. BUG= chromium:857603 TEST=Run lucifer test and lucifer admintask Change-Id: I44f9786e5a97bf008b7892637d729195331c072f Reviewed-on: https://chromium-review.googlesource.com/1119100 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [add] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/oldcmd/lucifer_run_job/main.go [rename] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/oldcmd/lucifer_run_job/os.go [modify] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/cmd/lucifer_run_job/main.go [rename] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/oldcmd/lucifer_run_job/metrics.go [add] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/cmd/lucifer/main.go [modify] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/cmd/lucifer_admin_task/main.go [rename] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/oldcmd/lucifer_run_job/autotest.go [rename] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/oldcmd/lucifer_run_job/events.go [add] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/oldcmd/lucifer_admin_task/main.go [rename] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/oldcmd/lucifer_run_job/os_test.go [rename] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/oldcmd/lucifer_run_job/task.go [rename] https://crrev.com/046a68949c4ed5ed0d395ada86d035148a47e153/src/lucifer/oldcmd/lucifer_run_job/flags.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9b74c3962342e99eab768bbbb7685ff60dec2d24 commit 9b74c3962342e99eab768bbbb7685ff60dec2d24 Author: Allen Li <ayatane@chromium.org> Date: Tue Jul 03 05:06:53 2018 lucifer: Add universal binary Add the new universal binary which uses subcommands so we dont have to keep touching this. BUG= chromium:857603 TEST=None CQ-DEPEND=CL:1119100 Change-Id: I3771cdaf793e16a35843597fb51b772c436a3b78 Reviewed-on: https://chromium-review.googlesource.com/1119105 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org> [modify] https://crrev.com/9b74c3962342e99eab768bbbb7685ff60dec2d24/chromeos-base/lucifer/lucifer-9999.ebuild
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/fa2ed0ea737c7be24ec279f25733b689fe9584c8 commit fa2ed0ea737c7be24ec279f25733b689fe9584c8 Author: Allen Li <ayatane@google.com> Date: Tue Jul 03 22:32:16 2018 lucifer: Use universal entry point BUG= chromium:857603 TEST=None CQ-DEPEND=CL:1119105 Change-Id: I63561ca34a1d42467310bf864567b31c79420a9e Reviewed-on: https://chromium-review.googlesource.com/1119107 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/fa2ed0ea737c7be24ec279f25733b689fe9584c8/src/lucifer/cmd/skylab_swarming_worker/internal/lucifer/lucifer.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/08fd214e57d05ee45c5b46c8ea9f4713c4dc3d32 commit 08fd214e57d05ee45c5b46c8ea9f4713c4dc3d32 Author: Allen Li <ayatane@chromium.org> Date: Fri Jul 06 19:20:45 2018 autotest: Use universal lucifer binary BUG= chromium:857603 TEST=None CQ-DEPEND=CL:1119105 Change-Id: I68865e035e40aa5a5409ad2cdb047157c19b6969 Reviewed-on: https://chromium-review.googlesource.com/1119117 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/08fd214e57d05ee45c5b46c8ea9f4713c4dc3d32/venv/lucifer/cmd/job_reporter.py [modify] https://crrev.com/08fd214e57d05ee45c5b46c8ea9f4713c4dc3d32/scheduler/luciferlib.py [modify] https://crrev.com/08fd214e57d05ee45c5b46c8ea9f4713c4dc3d32/venv/lucifer/cmd/job_aborter.py [modify] https://crrev.com/08fd214e57d05ee45c5b46c8ea9f4713c4dc3d32/venv/lucifer/eventlib.py [modify] https://crrev.com/08fd214e57d05ee45c5b46c8ea9f4713c4dc3d32/venv/lucifer/leasing.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/7c46e1941eb76e5c5d72845479e0a745ad1a1289 commit 7c46e1941eb76e5c5d72845479e0a745ad1a1289 Author: Allen Li <ayatane@google.com> Date: Sat Jul 07 01:48:13 2018 Move host info functions into atutil BUG= chromium:857603 TEST=None Change-Id: If78a3e0719dbcda25e869df3c50d42a7526709cb Reviewed-on: https://chromium-review.googlesource.com/1125265 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/autotest/atutil/types.go [modify] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/autotest/atutil/os.go [add] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/autotest/atutil/hostinfo.go [delete] https://crrev.com/334bd0ab26e5dee1c482cc19fc7b29b7adf56b62/src/lucifer/oldcmd/lucifer_run_job/os.go [modify] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/oldcmd/lucifer_run_job/autotest.go [modify] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/oldcmd/lucifer_run_job/main.go [modify] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/autotest/atutil/atutil.go [modify] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/oldcmd/lucifer_admin_task/main.go [modify] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/oldcmd/lucifer_run_job/flags.go [modify] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/oldcmd/lucifer_run_job/task.go [rename] https://crrev.com/7c46e1941eb76e5c5d72845479e0a745ad1a1289/src/lucifer/autotest/atutil/os_test.go
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0390901e29716c6a9957e4f44c59c95a9d713d55 commit 0390901e29716c6a9957e4f44c59c95a9d713d55 Author: Allen Li <ayatane@chromium.org> Date: Tue Jul 10 02:16:58 2018 autotest: Remove deprecated run-job-path BUG= chromium:857603 TEST=None Change-Id: I59b49e602d0eee82e19bd4c73d6d193ad173a131 Reviewed-on: https://chromium-review.googlesource.com/1125140 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/0390901e29716c6a9957e4f44c59c95a9d713d55/venv/lucifer/cmd/job_reporter.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/lucifer/+/10d2f2deb3750f9260df98cd6e16834ab9e859e5 commit 10d2f2deb3750f9260df98cd6e16834ab9e859e5 Author: Allen Li <ayatane@google.com> Date: Thu Jul 12 23:13:42 2018 lucifer: Remove old entry points BUG= chromium:857603 TEST=None Change-Id: I1c8e8c11467a95c7c827885614badf72189beeff Reviewed-on: https://chromium-review.googlesource.com/1134424 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [delete] https://crrev.com/6254d06b26e3f26b4aced9fbd871b84df152a74e/src/lucifer/cmd/lucifer_admin_task/main.go [delete] https://crrev.com/6254d06b26e3f26b4aced9fbd871b84df152a74e/src/lucifer/cmd/lucifer_run_job/main.go
Comment 1 by bugdroid1@chromium.org
, Jun 30 2018