Issue metadata
Sign in to add a comment
|
amd64-generic-asan: media-sound/adhd unittest is failing |
||||||||||||||||||||||||
Issue descriptionadhd-0.0.1-r1527: FAIL: dev_stream_unittest adhd-0.0.1-r1527: FAIL: fmt_conv_unittest adhd-0.0.1-r1527: FAIL: alsa_io_unittest The tests seem to be still running after this point, but the stage times out: TimeoutError: Timeout occurred- waited 5400.0 seconds. Reached UnitTestStage timeout. See build https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod/b8942472816741899760 for details.
,
Jun 28 2018
,
Jun 28 2018
,
Jul 3
Paul, have you started investigating this? It's making the amd64-generic-asan builder continually fail and need to be fixed (or the tests should be deleted if this isn't an actual problem). Is there someone else who would be a better owner for this?
,
Jul 4
I can reproduce the error on board=amd64-generic on commit 6e4ea41f031d2fa17b5a53e3897152be68a17ca1 now. I'll look into this tomorrow. Thanks for reminding me.
,
Jul 5
The NextAction date has arrived: 2018-07-05
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/ed59dbb4f2e909bd6ed7b884527bdd0d7727be2e commit ed59dbb4f2e909bd6ed7b884527bdd0d7727be2e Author: paulhsia <paulhsia@chromium.org> Date: Fri Jul 06 12:31:58 2018 adhd: Fix memory leak in cras_client_unittest.cc Free shm to prevent getting stuck in unittests with asan enable. BUG= chromium:857597 TEST=FEATURE=test USE=asan emerge-amd64-generic adhd Change-Id: I0a6ffa3ca99211a153b1abbae47db37b4ceaf7eb Reviewed-on: https://chromium-review.googlesource.com/1126880 Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/ed59dbb4f2e909bd6ed7b884527bdd0d7727be2e/cras/src/tests/cras_client_unittest.cc
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/b2f004b3310b6d32e23cd6179bed6961a32f5e63 commit b2f004b3310b6d32e23cd6179bed6961a32f5e63 Author: paulhsia <paulhsia@chromium.org> Date: Fri Jul 06 12:31:59 2018 adhd: Fix leaks and invalid memory access in alsa_io_unittest BUG= chromium:857597 TEST=FEATURE=test USE=asan emerge-amd64-generic adhd Change-Id: I75601b714a59148f72962700d161e2c7d7876da1 Reviewed-on: https://chromium-review.googlesource.com/1126881 Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/b2f004b3310b6d32e23cd6179bed6961a32f5e63/cras/src/tests/alsa_io_unittest.cc
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/6f26b2e1c7bb318a8eccb19679ee8f8f0dd7a34a commit 6f26b2e1c7bb318a8eccb19679ee8f8f0dd7a34a Author: paulhsia <paulhsia@chromium.org> Date: Fri Jul 06 12:32:00 2018 adhd: Fix memory leaks in fmt_conv_unittest and dev_stream_unittest BUG= chromium:857597 TEST=FEATURE=test USE=asan emerge-amd64-generic adhd Change-Id: Ie762c787bd1226e2d7f19c99c3d7a6fc86f1d8b5 Reviewed-on: https://chromium-review.googlesource.com/1126882 Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/6f26b2e1c7bb318a8eccb19679ee8f8f0dd7a34a/cras/src/tests/fmt_conv_unittest.cc [modify] https://crrev.com/6f26b2e1c7bb318a8eccb19679ee8f8f0dd7a34a/cras/src/tests/dev_stream_unittest.cc
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/1a75da06f25b9a79ba9509e5b087105cf4f35cd2 commit 1a75da06f25b9a79ba9509e5b087105cf4f35cd2 Author: paulhsia <paulhsia@chromium.org> Date: Fri Jul 06 14:53:57 2018 adhd: Fix undefined behavior in rclient_unittest We need to extract the value from misaligned address structure before comparing it with normal structure in EXPECT_EQ. BUG= chromium:857597 TEST=FEATURE=test USE=asan emerge-amd64-generic adhd Change-Id: I13ac7a84bdc935dc53190baeecc9a29e1606b0fe Reviewed-on: https://chromium-review.googlesource.com/1127201 Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/1a75da06f25b9a79ba9509e5b087105cf4f35cd2/cras/src/tests/rclient_unittest.cc
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/5bf79e714c928f3cd2a15ab1083a260b1c4cdc0e commit 5bf79e714c928f3cd2a15ab1083a260b1c4cdc0e Author: paulhsia <paulhsia@chromium.org> Date: Fri Jul 06 14:53:57 2018 adhd: Fix undefined behavior in cras_fmt_conv and its unittest Shifting negative integer is an undefined behavior. We need to cast them to unsigned integer explicitly before we use left shift. BUG= chromium:857597 TEST=FEATURE=test USE=asan emerge-amd64-generic adhd Change-Id: I641885ecd353fd3852de25ba271bc2419e1aac21 Reviewed-on: https://chromium-review.googlesource.com/1127504 Commit-Ready: Chih-Yang Hsia <paulhsia@chromium.org> Tested-by: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/5bf79e714c928f3cd2a15ab1083a260b1c4cdc0e/cras/src/tests/fmt_conv_unittest.cc [modify] https://crrev.com/5bf79e714c928f3cd2a15ab1083a260b1c4cdc0e/cras/src/server/cras_fmt_conv.c
,
Jul 9
Seems adhd completed compile with unittest and time out didn't occur on amd64-generic-tot-asan-informational. Please check the following link: https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Prod/b8941499631166086496 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rahulchaudhry@chromium.org
, Jun 28 2018